Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes health configuration optional #2104

Merged
merged 1 commit into from Sep 25, 2019
Merged

Makes health configuration optional #2104

merged 1 commit into from Sep 25, 2019

Conversation

codefromthecrypt
Copy link
Contributor

A previous change fixed health status mapping, but in the process made
it required to have health autoconfiguration. This fixes the below
error:

Parameter 3 of method actuatorServerConfigurator in com.linecorp.armeria.spring.actuate.ArmeriaSpringActuatorAutoConfiguration required a bean of type 'org.springframework.boot.actuate.health.HealthStatusHttpMapper' that could not be found.

A previous change fixed health status mapping, but in the process made
it required to have health autoconfiguration. This fixes the below
error:

```
Parameter 3 of method actuatorServerConfigurator in com.linecorp.armeria.spring.actuate.ArmeriaSpringActuatorAutoConfiguration required a bean of type 'org.springframework.boot.actuate.health.HealthStatusHttpMapper' that could not be found.
```
@trustin
Copy link
Member

trustin commented Sep 23, 2019

Thanks @adriancole !

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #2104 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #2104      +/-   ##
===========================================
- Coverage     73.71%   73.7%   -0.02%     
  Complexity     9466    9466              
===========================================
  Files           831     831              
  Lines         36495   36496       +1     
  Branches       4516    4516              
===========================================
- Hits          26903   26899       -4     
- Misses         7273    7279       +6     
+ Partials       2319    2318       -1
Impacted Files Coverage Δ Complexity Δ
...ctuate/ArmeriaSpringActuatorAutoConfiguration.java 97.61% <100%> (+0.05%) 12 <1> (+1) ⬆️
...om/linecorp/armeria/client/HttpSessionHandler.java 61.01% <0%> (-11.02%) 29% <0%> (-4%)
...necorp/armeria/server/GracefulShutdownSupport.java 97.43% <0%> (-2.57%) 4% <0%> (ø)
...a/common/grpc/protocol/ArmeriaMessageDeframer.java 69.9% <0%> (-1.46%) 45% <0%> (-2%)
.../linecorp/armeria/client/Http2ResponseDecoder.java 61.66% <0%> (+0.83%) 33% <0%> (+1%) ⬆️
...rp/armeria/common/stream/DefaultStreamMessage.java 90.71% <0%> (+1.42%) 54% <0%> (+1%) ⬆️
...om/linecorp/armeria/server/jetty/JettyService.java 66% <0%> (+2.95%) 24% <0%> (+1%) ⬆️
.../armeria/client/endpoint/dns/DnsEndpointGroup.java 86.31% <0%> (+3.15%) 15% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42c29ad...5fa10cc. Read the comment docs.

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trustin trustin merged commit 1f42f06 into line:master Sep 25, 2019
@codefromthecrypt codefromthecrypt deleted the in-case-no-health branch October 14, 2019 03:24
eugene70 pushed a commit to eugene70/armeria that referenced this pull request Oct 16, 2019
A previous change fixed health status mapping, but in the process made
it required to have health autoconfiguration. This fixes the below
error:

```
Parameter 3 of method actuatorServerConfigurator in com.linecorp.armeria.spring.actuate.ArmeriaSpringActuatorAutoConfiguration required a bean of type 'org.springframework.boot.actuate.health.HealthStatusHttpMapper' that could not be found.
```
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
A previous change fixed health status mapping, but in the process made
it required to have health autoconfiguration. This fixes the below
error:

```
Parameter 3 of method actuatorServerConfigurator in com.linecorp.armeria.spring.actuate.ArmeriaSpringActuatorAutoConfiguration required a bean of type 'org.springframework.boot.actuate.health.HealthStatusHttpMapper' that could not be found.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants