New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes health configuration optional #2104
Conversation
A previous change fixed health status mapping, but in the process made it required to have health autoconfiguration. This fixes the below error: ``` Parameter 3 of method actuatorServerConfigurator in com.linecorp.armeria.spring.actuate.ArmeriaSpringActuatorAutoConfiguration required a bean of type 'org.springframework.boot.actuate.health.HealthStatusHttpMapper' that could not be found. ```
Thanks @adriancole ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
===========================================
- Coverage 73.71% 73.7% -0.02%
Complexity 9466 9466
===========================================
Files 831 831
Lines 36495 36496 +1
Branches 4516 4516
===========================================
- Hits 26903 26899 -4
- Misses 7273 7279 +6
+ Partials 2319 2318 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
A previous change fixed health status mapping, but in the process made it required to have health autoconfiguration. This fixes the below error: ``` Parameter 3 of method actuatorServerConfigurator in com.linecorp.armeria.spring.actuate.ArmeriaSpringActuatorAutoConfiguration required a bean of type 'org.springframework.boot.actuate.health.HealthStatusHttpMapper' that could not be found. ```
A previous change fixed health status mapping, but in the process made it required to have health autoconfiguration. This fixes the below error: ``` Parameter 3 of method actuatorServerConfigurator in com.linecorp.armeria.spring.actuate.ArmeriaSpringActuatorAutoConfiguration required a bean of type 'org.springframework.boot.actuate.health.HealthStatusHttpMapper' that could not be found. ```
A previous change fixed health status mapping, but in the process made
it required to have health autoconfiguration. This fixes the below
error: