Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies #2205

Merged
merged 4 commits into from Oct 25, 2019
Merged

Update Dependencies #2205

merged 4 commits into from Oct 25, 2019

Conversation

minwoox
Copy link
Member

@minwoox minwoox commented Oct 23, 2019

  • BOM
    • Use Micrometer BOM 1.3.0
  • Brave 5.7.0 -> 5.8.0
  • Dropwizard 4.1.0 -> 4.1.1
  • gax-grpc 1.49.0 -> 1.49.1
  • gRPC 1.24.0 -> 1.24.1
  • Netty 4.1.42 -> 4.1.43
  • org.bouncycastle 1.63 -> 1.64
  • Proguard 6.1.1 -> 6.2.0
  • Prometheus 0.7.0 -> 0.8.0
  • RxJava2 2.2.12 -> 2.2.13
  • Spring Boot 2.1.8 -> 2.1.9
  • Tomcat
    • 9.0.26 -> 9.0.27
    • 8.5.43 -> 8.5.47
  • ZooKeeper 3.5.5 -> 3.5.6
  • Build
    • Gradle 5.6.2 -> 5.6.3

@minwoox minwoox added this to the 0.95.0 milestone Oct 23, 2019
@@ -408,7 +406,7 @@ org.slf4j:

org.springframework.boot:
spring-boot-starter:
version: &SPRING_BOOT_VERSION '2.1.8.RELEASE'
version: &SPRING_BOOT_VERSION '2.1.9.RELEASE'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have decided to update to 2.1.9 because 2.2.0 does not support Tomcat 8.5. So this release(Armeria 0.95.0) will be the last release which supports Tomcat 8.5.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool.. thanks for update. also the things available for performance in boot 2.2 are actually spring related and may imply some refactoring as options were added to the @Configuration annotation. It may not actually require refactoring, but anyway.

- Use Micrometer BOM 1.3.0

- Brave 5.7.0 -> 5.8.0
- Dropwizard 4.1.0 -> 4.1.1
- gax-grpc 1.49.0 -> 1.49.1
- org.bouncycastle 1.63 -> 1.64
- Proguard 6.1.1 -> 6.2.0
- RxJava2 2.2.12 -> 2.2.13
- Spring Boot 2.1.8 -> 2.1.9
- Tomcat
  - 9.0.26 -> 9.0.27
  - 8.5.43 -> 8.5.47
- ZooKeeper 3.5.5 -> 3.5.6
- Build
  - Gradle 5.6.2 -> 5.6.3
@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #2205 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2205      +/-   ##
============================================
+ Coverage     73.59%   73.62%   +0.02%     
- Complexity     9589     9619      +30     
============================================
  Files           838      840       +2     
  Lines         36944    37041      +97     
  Branches       4554     4566      +12     
============================================
+ Hits          27190    27271      +81     
- Misses         7429     7443      +14     
- Partials       2325     2327       +2
Impacted Files Coverage Δ Complexity Δ
...a/com/linecorp/armeria/internal/DefaultValues.java 66.66% <0%> (-33.34%) 4% <0%> (-1%)
...n/java/com/linecorp/armeria/server/HttpServer.java 40% <0%> (-20%) 2% <0%> (-1%)
...meria/common/stream/RegularFixedStreamMessage.java 81.63% <0%> (-6.13%) 13% <0%> (-1%)
...om/linecorp/armeria/client/HttpSessionHandler.java 58.47% <0%> (-2.55%) 27% <0%> (-2%)
...a/com/linecorp/armeria/common/util/Exceptions.java 38.59% <0%> (-0.88%) 24% <0%> (-1%)
...a/com/linecorp/armeria/common/util/SystemInfo.java 25.46% <0%> (-0.85%) 6% <0%> (ø)
...com/linecorp/armeria/server/HttpServerHandler.java 80.73% <0%> (-0.67%) 81% <0%> (-1%)
...c/main/java/com/linecorp/armeria/common/Flags.java 61.03% <0%> (-0.64%) 54% <0%> (+1%)
...ommon/brave/RequestContextCurrentTraceContext.java 97.1% <0%> (-0.43%) 24% <0%> (+2%)
...inecorp/armeria/server/HttpResponseSubscriber.java 85.04% <0%> (-0.43%) 75% <0%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca8e3c...594616a. Read the comment docs.

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@minwoox minwoox merged commit e8716d6 into line:master Oct 25, 2019
@minwoox minwoox deleted the update_deps branch October 25, 2019 05:53
@minwoox
Copy link
Member Author

minwoox commented Oct 25, 2019

Thanks for reviewing!

eugene70 pushed a commit to eugene70/armeria that referenced this pull request Nov 10, 2019
- BOM
  - Use Micrometer BOM 1.3.0
- Brave 5.7.0 -> 5.8.0
- Dropwizard 4.1.0 -> 4.1.1
- gax-grpc 1.49.0 -> 1.49.1
- gRPC 1.24.0 -> 1.24.1
- Netty 4.1.42 -> 4.1.43
- org.bouncycastle 1.63 -> 1.64
- Proguard 6.1.1 -> 6.2.0
- Prometheus 0.7.0 -> 0.8.0
- RxJava2 2.2.12 -> 2.2.13
- Spring Boot 2.1.8 -> 2.1.9
- Tomcat
  - 9.0.26 -> 9.0.27
  - 8.5.43 -> 8.5.47
- ZooKeeper 3.5.5 -> 3.5.6
- Build
  - Gradle 5.6.2 -> 5.6.3
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
- BOM
  - Use Micrometer BOM 1.3.0
- Brave 5.7.0 -> 5.8.0
- Dropwizard 4.1.0 -> 4.1.1
- gax-grpc 1.49.0 -> 1.49.1
- gRPC 1.24.0 -> 1.24.1
- Netty 4.1.42 -> 4.1.43
- org.bouncycastle 1.63 -> 1.64
- Proguard 6.1.1 -> 6.2.0
- Prometheus 0.7.0 -> 0.8.0
- RxJava2 2.2.12 -> 2.2.13
- Spring Boot 2.1.8 -> 2.1.9
- Tomcat
  - 9.0.26 -> 9.0.27
  - 8.5.43 -> 8.5.47
- ZooKeeper 3.5.5 -> 3.5.6
- Build
  - Gradle 5.6.2 -> 5.6.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants