Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-configuration to support GrpcServiceRegistrationBeans… #2234

Merged
merged 1 commit into from Nov 7, 2019

Conversation

mauhiz
Copy link
Contributor

@mauhiz mauhiz commented Nov 6, 2019

For people who can't wait for the next release, a simple workaround is to invoke armeriaServer with an empty list of Thrift services as well (Optional.of(emptyList()))

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #2234 into master will decrease coverage by 0.04%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2234      +/-   ##
============================================
- Coverage     73.52%   73.47%   -0.05%     
+ Complexity     9748     9734      -14     
============================================
  Files           849      849              
  Lines         37555    37556       +1     
  Branches       4610     4611       +1     
============================================
- Hits          27611    27594      -17     
- Misses         7583     7601      +18     
  Partials       2361     2361
Impacted Files Coverage Δ Complexity Δ
...ecorp/armeria/spring/ArmeriaAutoConfiguration.java 78.72% <50%> (-1.72%) 11 <0> (ø)
...n/java/com/linecorp/armeria/server/HttpServer.java 40% <0%> (-20%) 2% <0%> (-1%)
...inecorp/armeria/client/AbstractEventLoopState.java 92.3% <0%> (-7.7%) 6% <0%> (-1%)
...corp/armeria/client/DefaultEventLoopScheduler.java 79.27% <0%> (-7.21%) 30% <0%> (-3%)
...com/linecorp/armeria/client/OneEventLoopState.java 66.66% <0%> (-4.77%) 6% <0%> (-1%)
.../linecorp/armeria/client/retrofit2/PipeBuffer.java 79.06% <0%> (-4.66%) 6% <0%> (ø)
...client/endpoint/healthcheck/HttpHealthChecker.java 85.29% <0%> (-2.95%) 18% <0%> (-1%)
...om/linecorp/armeria/client/HttpSessionHandler.java 58.47% <0%> (-2.55%) 27% <0%> (-2%)
...inecorp/armeria/server/grpc/ArmeriaServerCall.java 87.1% <0%> (-1.57%) 85% <0%> (-1%)
...necorp/armeria/client/HeapBasedEventLoopState.java 92.78% <0%> (-1.04%) 31% <0%> (-1%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d3184...c529c66. Read the comment docs.

@trustin trustin added the defect label Nov 6, 2019
@trustin trustin added this to the 0.96.0 milestone Nov 6, 2019
Copy link
Collaborator

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @mauhiz !

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks, @mauhiz 👍

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@trustin trustin changed the title Fix auto-configuration to support grpcServiceRegistrationBeans only Fix auto-configuration to support GrpcServiceRegistrationBeans… Nov 7, 2019
@trustin trustin merged commit a72d44d into line:master Nov 7, 2019
eugene70 pushed a commit to eugene70/armeria that referenced this pull request Nov 10, 2019
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants