New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix auto-configuration to support GrpcServiceRegistrationBeans… #2234
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2234 +/- ##
============================================
- Coverage 73.52% 73.47% -0.05%
+ Complexity 9748 9734 -14
============================================
Files 849 849
Lines 37555 37556 +1
Branches 4610 4611 +1
============================================
- Hits 27611 27594 -17
- Misses 7583 7601 +18
Partials 2361 2361
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @mauhiz !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Thanks, @mauhiz 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
For people who can't wait for the next release, a simple workaround is to invoke
armeriaServer
with an empty list of Thrift services as well (Optional.of(emptyList())
)