-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade Reflections from 0.9.12 to 0.9.11 #2519
Conversation
.. due to a known regression: ronmamo/reflections#279
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! By the way don’t we need to revert our defense logic which was added by #2494
It's harmless, so I'd like to keep it so I don't have to add it again when upgrading. |
Codecov Report
@@ Coverage Diff @@
## master #2519 +/- ##
============================================
- Coverage 73.03% 73.00% -0.03%
+ Complexity 10860 10854 -6
============================================
Files 947 947
Lines 41879 41879
Branches 5183 5183
============================================
- Hits 30585 30574 -11
- Misses 8649 8662 +13
+ Partials 2645 2643 -2 Continue to review full report at Codecov.
|
.. due to a known regression: ronmamo/reflections#279
.. due to a known regression: ronmamo/reflections#279
.. due to a known regression: ronmamo/reflections#279
.. due to a known regression: ronmamo/reflections#279
Fixes #2518