Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Reflections from 0.9.12 to 0.9.11 #2519

Merged
merged 3 commits into from
Feb 21, 2020

Conversation

trustin
Copy link
Member

@trustin trustin commented Feb 21, 2020

.. due to a known regression: ronmamo/reflections#279

Fixes #2518

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! By the way don’t we need to revert our defense logic which was added by #2494

@trustin
Copy link
Member Author

trustin commented Feb 21, 2020

By the way don’t we need to revert our defense logic which was added by #2494

It's harmless, so I'd like to keep it so I don't have to add it again when upgrading.

@trustin trustin removed the request for review from minwoox February 21, 2020 05:03
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #2519 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2519      +/-   ##
============================================
- Coverage     73.03%   73.00%   -0.03%     
+ Complexity    10860    10854       -6     
============================================
  Files           947      947              
  Lines         41879    41879              
  Branches       5183     5183              
============================================
- Hits          30585    30574      -11     
- Misses         8649     8662      +13     
+ Partials       2645     2643       -2     
Impacted Files Coverage Δ Complexity Δ
...meria/common/stream/RegularFixedStreamMessage.java 81.63% <0.00%> (-6.13%) 13.00% <0.00%> (-1.00%)
...a/com/linecorp/armeria/client/HttpChannelPool.java 77.95% <0.00%> (-2.37%) 63.00% <0.00%> (-2.00%)
...rmeria/internal/server/ResponseConversionUtil.java 85.71% <0.00%> (-2.05%) 10.00% <0.00%> (ø%)
.../com/linecorp/armeria/server/docs/ServiceInfo.java 78.94% <0.00%> (-1.76%) 20.00% <0.00%> (-1.00%)
.../armeria/client/endpoint/dns/DnsEndpointGroup.java 78.68% <0.00%> (-1.64%) 12.00% <0.00%> (-1.00%)
.../com/linecorp/armeria/server/RoutingPredicate.java 69.35% <0.00%> (-1.62%) 20.00% <0.00%> (-1.00%)
.../linecorp/armeria/client/Http2ResponseDecoder.java 63.02% <0.00%> (-0.85%) 34.00% <0.00%> (-1.00%)
...java/com/linecorp/armeria/server/DefaultRoute.java 95.42% <0.00%> (-0.66%) 73.00% <0.00%> (-1.00%)
...armeria/server/healthcheck/HealthCheckService.java 85.65% <0.00%> (+0.44%) 53.00% <0.00%> (+1.00%) ⬇️
...inecorp/armeria/server/grpc/ArmeriaServerCall.java 88.28% <0.00%> (+0.78%) 85.00% <0.00%> (-1.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a5e75...a8c7a81. Read the comment docs.

@trustin trustin merged commit 40a6eb3 into line:master Feb 21, 2020
@trustin trustin deleted the downgrade_reflections branch February 21, 2020 05:13
jrhee17 pushed a commit to jrhee17/armeria that referenced this pull request Feb 22, 2020
heowc pushed a commit to heowc/armeria that referenced this pull request Feb 25, 2020
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReflectionsException while extracting doc strings
2 participants