-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FilteredStreamMessage.onCancellation() #3375
Merged
Merged
Commits on Mar 9, 2021
-
Add beforeCancel hook to FilteredStreamMessage
Motivation: An implementation of the `FilteredStreamMessage` might have resources to release when the `StreamMessage` is complete. For example, an `HttpResponse` from `ContentPreviewingService` should call `ContentPreviewer.produce()` to release the resource and produce the content preview. However, the `FilteredStreamMessage` is not notified when the `StreamMessage` is canceled by the `Subscriber`. Modification: - Add `FilteredStreamMessage.beforeCancel()` so that an implementation of the message can add a hook before `Subscription.cancel()`. Result: - You no longer see that the log is not complete when applying `ContentPreviewingService`.
Configuration menu - View commit details
-
Copy full SHA for a7f0c67 - Browse repository at this point
Copy the full SHA a7f0c67View commit details -
Configuration menu - View commit details
-
Copy full SHA for dceb402 - Browse repository at this point
Copy the full SHA dceb402View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56a9423 - Browse repository at this point
Copy the full SHA 56a9423View commit details -
Configuration menu - View commit details
-
Copy full SHA for 052bc0a - Browse repository at this point
Copy the full SHA 052bc0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b27e91 - Browse repository at this point
Copy the full SHA 0b27e91View commit details
Commits on Mar 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3b2e245 - Browse repository at this point
Copy the full SHA 3b2e245View commit details
Commits on Mar 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d4ab16d - Browse repository at this point
Copy the full SHA d4ab16dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 232b241 - Browse repository at this point
Copy the full SHA 232b241View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1379526 - Browse repository at this point
Copy the full SHA 1379526View commit details
Commits on Mar 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a0b99a9 - Browse repository at this point
Copy the full SHA a0b99a9View commit details
Commits on Mar 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cd89b76 - Browse repository at this point
Copy the full SHA cd89b76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5245539 - Browse repository at this point
Copy the full SHA 5245539View commit details
Commits on Mar 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2a70d7f - Browse repository at this point
Copy the full SHA 2a70d7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe7cd85 - Browse repository at this point
Copy the full SHA fe7cd85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cdc0b3 - Browse repository at this point
Copy the full SHA 3cdc0b3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.