Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FilteredStreamMessage.onCancellation() #3375

Merged
merged 15 commits into from Mar 26, 2021
Merged

Commits on Mar 9, 2021

  1. Add beforeCancel hook to FilteredStreamMessage

    Motivation:
    An implementation of the `FilteredStreamMessage` might have resources to release when
    the `StreamMessage` is complete. For example, an `HttpResponse` from `ContentPreviewingService` should call
    `ContentPreviewer.produce()` to release the resource and produce the content preview.
    However, the `FilteredStreamMessage` is not notified when the `StreamMessage` is canceled by the `Subscriber`.
    
    Modification:
    - Add `FilteredStreamMessage.beforeCancel()` so that an implementation of the message
      can add a hook before `Subscription.cancel()`.
    
    Result:
    - You no longer see that the log is not complete when applying `ContentPreviewingService`.
    minwoox committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    a7f0c67 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dceb402 View commit details
    Browse the repository at this point in the history
  3. Address the comment by @ikhoon

    minwoox committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    56a9423 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    052bc0a View commit details
    Browse the repository at this point in the history
  5. Fix comments

    minwoox committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    0b27e91 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Update Javadoc

    minwoox committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    3b2e245 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Rephrease Javadoc

    minwoox committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    d4ab16d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    232b241 View commit details
    Browse the repository at this point in the history
  3. Add onCancellation

    minwoox committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    1379526 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Remove Subscriber

    minwoox committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    a0b99a9 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Address the comment by @trustin

    minwoox committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    cd89b76 View commit details
    Browse the repository at this point in the history
  2. Fix flaky

    minwoox committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    5245539 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Configuration menu
    Copy the full SHA
    2a70d7f View commit details
    Browse the repository at this point in the history
  2. Fix compile

    minwoox committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    fe7cd85 View commit details
    Browse the repository at this point in the history
  3. Address comments by @trustin

    minwoox committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    3cdc0b3 View commit details
    Browse the repository at this point in the history