Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pseudo headers when converting to Spring headers #4293

Merged
merged 4 commits into from
Jul 1, 2022

Commits on Jun 8, 2022

  1. Remove pseudo headers when converting to Spring headers

    Motivation:
    We store HTTP/2 pseudo headers to the map in `HttpHeaders` with other headers.
    Then, the entries of the map are copied to Spring `HttpHeaders` in Spring integration.
    However, it can be a problem when the copied Spring `HttpHeaders` is converted to Netty Headers later:
    https://github.com/spring-cloud/spring-cloud-gateway/blob/v3.1.3/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/NettyRoutingFilter.java#L125-L128
    The validation is failed when the pseudo headers are set.
    
    Modifications:
    - Remove HTTP/2 pseudo headers when creating Spring `HttpHeaders` from Armeria `HttpHeaders`.
      - Convert `:authority` header to `HOST` header.
    
    Result:
    - You no longer see `IllegalArgumentException` indicating prohibited character of a header name
      in an environment that Spring integration module and Netty client are used togeter.(e.g. Spring Cloud Gateway)
    minwoox committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    8380608 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Configuration menu
    Copy the full SHA
    f1df421 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Address the comment by @ikhoon

    minwoox committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    0b2e5e2 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Rename to key

    minwoox committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    128b420 View commit details
    Browse the repository at this point in the history