Respond with application/json for httpjson transcoding endpoints #4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscheong01
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
minwoox
approved these changes
Oct 11, 2022
| @@ -603,7 +602,7 @@ private HttpResponse serve0(ServiceRequestContext ctx, HttpRequest req, | |||
| ctx.setAttr(FramedGrpcService.RESOLVED_GRPC_METHOD, spec.method); | |||
| frameAndServe(unwrap(), ctx, grpcHeaders.build(), | |||
| convertToJson(ctx, clientRequest, spec), | |||
| responseFuture, generateResponseBodyConverter(spec), jsonContentType); | |||
| responseFuture, generateResponseBodyConverter(spec), MediaType.JSON_UTF_8); | |||
There was a problem hiding this comment.
nit: Let's leave a link to this https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/grpc_json_transcoder_filter#sending-arbitrary-content that explains why we set JSON media type.
jrhee17
approved these changes
Oct 11, 2022
|
Can you also check the lint failures? 😅 |
Codecov ReportBase: 74.04% // Head: 74.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4474 +/- ##
============================================
+ Coverage 74.04% 74.08% +0.03%
- Complexity 18164 18173 +9
============================================
Files 1536 1536
Lines 67379 67378 -1
Branches 8520 8520
============================================
+ Hits 49889 49914 +25
+ Misses 13416 13401 -15
+ Partials 4074 4063 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Wrong response contenttype served for http json transcoding endpoints as result of #4364
Modifications:
Result:
application/jsonbutapplicaiton/grpc+json#4473