Eureka: Remove encoded port from VIP address defaults

[codefromthecrypt]

Motivation:

Currently, when armeria registers a server, it appends :${port} to Eureka VIP addresses to. While it makes sense to encode the port into the Eureka serviceId, the VIP address fields are meant to be hostnames or IPs. Encoding a port into the VIP address makes these unusable for certain clients like spring-cloud-sleuth who heuristically look for a port and only if it is absent trigger Eureka lookups.

Modifications:

• I removed the logic that appended :${port} to both the vipAddress and secureVipAddress
• I changed the test which actually proved the bug was present!

Result:

• Manual integration with zipkin, sleuth is now able to look up its endpoint in Eureka.

[codefromthecrypt]

this check is still helpful as it avoids adding secureVipAddress when there's no secure port

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a117c25) 73.99% compared to head (6221885) 74.00%.
Report is 2 commits behind head on main.

❗ Current head 6221885 differs from pull request most recent head 4af19ac. Consider uploading reports for the commit 4af19ac to get more accurate results

Files	Patch %	Lines
.../armeria/server/eureka/EurekaUpdatingListener.java	62.50%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #5451   +/-   ##
=========================================
  Coverage     73.99%   74.00%           
- Complexity    20740    20748    +8     
=========================================
  Files          1800     1800           
  Lines         76426    76431    +5     
  Branches       9728     9728           
=========================================
+ Hits          56552    56561    +9     
- Misses        15266    15267    +1     
+ Partials       4608     4603    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🔍 Build Scan® (commit: 4af19ac)

Job name	Status	Build Scan®
build-windows-latest-jdk-19	✅	https://ge.armeria.dev/s/dnijrhixslolg
build-self-hosted-unsafe-jdk-8	✅	https://ge.armeria.dev/s/2sodiu2uuyuhs
build-self-hosted-unsafe-jdk-19-snapshot-blockhound	✅	https://ge.armeria.dev/s/5spl67357f34s
build-self-hosted-unsafe-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/k3rojpsrezrvi
build-self-hosted-unsafe-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/wpffwfber2bz2
build-self-hosted-unsafe-jdk-17-leak	✅	https://ge.armeria.dev/s/avctqsbpjcnrc
build-self-hosted-unsafe-jdk-11	❌ (failure)	https://ge.armeria.dev/s/p2holn3vtbilc
build-macos-12-jdk-19	✅	https://ge.armeria.dev/s/ltbifsgvhoqza

[codefromthecrypt]

fixed the description

[codefromthecrypt]

test flake is unrelated

[codefromthecrypt]

ps the really really long story about this small bug https://github.com/openzipkin/zipkin/releases/tag/3.0.6

[minwoox]

I apologize for the lack of integration testing and greatly appreciate your effort!

[codefromthecrypt]

there seems to be another glitch which I will look into (past this). More UX related? openzipkin/zipkin#3697 (comment)

[jrhee17]

Thanks @codefromthecrypt 🙇 👍 🙇

[ikhoon]

Thanks!! 🙇‍♂️