-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove armeria-brave module #5453
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Copyright 2019 LINE Corporation | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. using 2024 for new file? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe this wasn't a new file because we used to have it but we moved it to another module and back here again. 😆 So let me just keep the year. |
||
* | ||
* LINE Corporation licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
/** | ||
* Distributed tracing services based on <a href="https://github.com/openzipkin/brave">Brave</a>, | ||
* a Java tracing library compatible with <a href="http://zipkin.io/">Zipkin</a>. | ||
* | ||
* @deprecated Use armeria-brave6 module. | ||
* See <a href="https://armeria.dev/release-notes/1.28.0#%EF%B8%8F-breaking-changes"> | ||
* 1.28 Breaking Changes</a> for more information. | ||
*/ | ||
@Deprecated | ||
@NonNullByDefault | ||
package com.linecorp.armeria.client.brave; | ||
|
||
import com.linecorp.armeria.common.annotation.NonNullByDefault; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Copyright 2019 LINE Corporation | ||
* | ||
* LINE Corporation licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
/** | ||
* Distributed tracing services based on <a href="https://github.com/openzipkin/brave">Brave</a>, | ||
* a Java tracing library compatible with <a href="http://zipkin.io/">Zipkin</a>. | ||
* | ||
* @deprecated Use armeria-brave6 module. | ||
* See <a href="https://armeria.dev/release-notes/1.28.0#%EF%B8%8F-breaking-changes"> | ||
* 1.28 Breaking Changes</a> for more information. | ||
*/ | ||
@Deprecated | ||
@NonNullByDefault | ||
package com.linecorp.armeria.common.brave; | ||
|
||
import com.linecorp.armeria.common.annotation.NonNullByDefault; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Copyright 2019 LINE Corporation | ||
* | ||
* LINE Corporation licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
/** | ||
* Distributed tracing services based on <a href="https://github.com/openzipkin/brave">Brave</a>, | ||
* a Java tracing library compatible with <a href="http://zipkin.io/">Zipkin</a>. | ||
* | ||
* @deprecated Use armeria-brave6 module. | ||
* See <a href="https://armeria.dev/release-notes/1.28.0#%EF%B8%8F-breaking-changes"> | ||
* 1.28 Breaking Changes</a> for more information. | ||
*/ | ||
@Deprecated | ||
@NonNullByDefault | ||
package com.linecorp.armeria.internal.common.brave; | ||
|
||
import com.linecorp.armeria.common.annotation.NonNullByDefault; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Copyright 2019 LINE Corporation | ||
* | ||
* LINE Corporation licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
/** | ||
* Distributed tracing services based on <a href="https://github.com/openzipkin/brave">Brave</a>, | ||
* a Java tracing library compatible with <a href="http://zipkin.io/">Zipkin</a>. | ||
* | ||
* @deprecated Use armeria-brave6 module. | ||
* See <a href="https://armeria.dev/release-notes/1.28.0#%EF%B8%8F-breaking-changes"> | ||
* 1.28 Breaking Changes</a> for more information. | ||
*/ | ||
@Deprecated | ||
@NonNullByDefault | ||
package com.linecorp.armeria.server.brave; | ||
|
||
import com.linecorp.armeria.common.annotation.NonNullByDefault; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious do we prefer to use the convention like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you let me know if you are suggesting this convention? Or are you just asking? 😆
If you are suggesting it, could you share the reason, please? 😉 cc @jrhee17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe both, it's good to avoid some configuration time. And saw our native-image-config using similar way.
Notice this recently https://docs.gradle.org/current/userguide/task_configuration_avoidance.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for sharing the link. I wasn't aware that we were using an anti-pattern. 😓 Since we've employed this pattern across all our build files, let me create another PR to address this issue.