Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle an empty query parameter with @Default #5534

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Handle an empty query parameter with @Default #5534

merged 4 commits into from
Apr 4, 2024

Commits on Mar 27, 2024

  1. Handle an empty query parameter with @default 

      - if the type of the parameter is primitive, throw exception
  - if the type of the parameter is collection, empty collection
  - add test cases
    @facewise
    facewise committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c0222f1 View commit details
    Browse the repository at this point in the history

  2. Remove warning log and fix bug

    @facewise
    facewise committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4406035 View commit details
    Browse the repository at this point in the history

  3. Add e2e test EmptyParameterWithDefaultAnnotationTest

    @facewise
    facewise committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d121b9b View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Replace javadoc of @default#value() with suggestion 

    Co-authored-by: jrhee17 <guins_j@guins.org>
    @facewise @jrhee17
    facewise and jrhee17 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d30a857 View commit details
    Browse the repository at this point in the history