Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GrpcStatus to implement GrpcExceptionHandlerFunction #5571

Merged
merged 32 commits into from
May 20, 2024
Merged

Refactor GrpcStatus to implement GrpcExceptionHandlerFunction #5571

merged 32 commits into from
May 20, 2024

Commits on Apr 5, 2024

  1. chore: refactor GrpcStatus to use it as DefaultGrpcExceptionHandlerFu… 

    …nction
    @jaeseung-bae
    jaeseung-bae committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c33f8ea View commit details
    Browse the repository at this point in the history

  2. test: can use DefaultGrpcExceptionHandlerFunction for server builder … 

    …and client builder
    @jaeseung-bae
    jaeseung-bae committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    30dd216 View commit details
    Browse the repository at this point in the history

  3. chore: lint fix

    @jaeseung-bae
    jaeseung-bae committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    866a041 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. chore: refactor, move exceptionHandling features from GrpcStatus to D… 

    …efaultGrpcExceptionHandlerFunction
    @jaeseung-bae
    jaeseung-bae committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    3a5585f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into refactor/grpc-status

    @jaeseung-bae
    jaeseung-bae committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    1e0a4d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. chore: use DefaultGrpcExceptionHandlerFunction as fallback for both G… 

    …rpcClient and GrpcServer
    @jaeseung-bae
    jaeseung-bae committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    0c804ef View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. chore: try to add possibly missing description in case of replace_exc… 

    …eption server interceptor added
    @jaeseung-bae
    jaeseung-bae committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a88f3c3 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into refactor/grpc-status

    @jaeseung-bae
    jaeseung-bae committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    cccbe7d View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. chore: apply feedbacks

    @jaeseung-bae
    jaeseung-bae committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5c56c80 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. chore: call peelAndUnwrap when exception thrown

    @jaeseung-bae
    jaeseung-bae committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0d6f75c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into HEAD

    @jaeseung-bae
    jaeseung-bae committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d38f3be View commit details
    Browse the repository at this point in the history

  3. chore: UnwrappingGrpcExceptionHandlerFunction calls peelAndUnwrap at … 

    …the most first of exception-handling
    @jaeseung-bae
    jaeseung-bae committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8604cf5 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. chore: peelAndUnwrap is not supposed to receive null Throwable

    @jaeseung-bae
    jaeseung-bae committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    0bd68e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Update grpc/src/main/java/com/linecorp/armeria/common/grpc/GrpcExcept… 

    …ionHandlerFunction.java

Co-authored-by: Ikhun Um <ih.pert@gmail.com>
    @jaeseung-bae @ikhoon
    jaeseung-bae and ikhoon committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    63737b1 View commit details
    Browse the repository at this point in the history

  2. Update grpc/src/main/java/com/linecorp/armeria/internal/common/grpc/U… 

    …nwrappingGrpcExceptionHandleFunction.java

Co-authored-by: Ikhun Um <ih.pert@gmail.com>
    @jaeseung-bae @ikhoon
    jaeseung-bae and ikhoon committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    fb0692a View commit details
    Browse the repository at this point in the history

  3. chore: apply feedbacks

    @jaeseung-bae
    jaeseung-bae committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f68bd28 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Merge branch 'main' into refactor/grpc-status

    @ikhoon
    ikhoon committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    894fbba View commit details
    Browse the repository at this point in the history

  2. Update grpc/src/test/java/com/linecorp/armeria/common/grpc/GrpcExcept… 

    …ionHandlerFunctionBuilderTest.java

Co-authored-by: Ikhun Um <ih.pert@gmail.com>
    @jaeseung-bae @ikhoon
    jaeseung-bae and ikhoon committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7090d2c View commit details
    Browse the repository at this point in the history

  3. Update grpc/src/test/java/com/linecorp/armeria/common/grpc/GrpcExcept… 

    …ionHandlerFunctionBuilderTest.java

Co-authored-by: Ikhun Um <ih.pert@gmail.com>
    @jaeseung-bae @ikhoon
    jaeseung-bae and ikhoon committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a35dc16 View commit details
    Browse the repository at this point in the history

  4. Update grpc/src/test/java/com/linecorp/armeria/common/grpc/GrpcExcept… 

    …ionHandlerFunctionBuilderTest.java

Co-authored-by: Ikhun Um <ih.pert@gmail.com>
    @jaeseung-bae @ikhoon
    jaeseung-bae and ikhoon committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a9a28ba View commit details
    Browse the repository at this point in the history

  5. Update grpc/src/test/java/com/linecorp/armeria/common/grpc/GrpcExcept… 

    …ionHandlerFunctionBuilderTest.java

Co-authored-by: Ikhun Um <ih.pert@gmail.com>
    @jaeseung-bae @ikhoon
    jaeseung-bae and ikhoon committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0704f71 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. chore: revert redundant wrapping code

    @jaeseung-bae
    jaeseung-bae committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e7b9908 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Merge remote-tracking branch 'upstream/main' into refactor/grpc-status

    @jaeseung-bae
    jaeseung-bae committed May 18, 2024
    Configuration menu
    Copy the full SHA
    7244059 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. chore: make enum for singleton instance

    @jaeseung-bae
    jaeseung-bae committed May 19, 2024
    Configuration menu
    Copy the full SHA
    10245db View commit details
    Browse the repository at this point in the history

  2. chore: rename ofDefault to of to meet recent convention

    @jaeseung-bae
    jaeseung-bae committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c717229 View commit details
    Browse the repository at this point in the history

  3. chore: add comment

    @jaeseung-bae
    jaeseung-bae committed May 19, 2024
    Configuration menu
    Copy the full SHA
    81f3d3a View commit details
    Browse the repository at this point in the history

  4. chore: add assertion for newStatus

    @jaeseung-bae
    jaeseung-bae committed May 19, 2024
    Configuration menu
    Copy the full SHA
    d1ff8b9 View commit details
    Browse the repository at this point in the history

  5. chore: make it final, static

    @jaeseung-bae
    jaeseung-bae committed May 19, 2024
    Configuration menu
    Copy the full SHA
    9603904 View commit details
    Browse the repository at this point in the history

  6. chore: fix lint

    @jaeseung-bae
    jaeseung-bae committed May 19, 2024
    Configuration menu
    Copy the full SHA
    5b6dba4 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. chore: refactoring for clean code

    @jaeseung-bae
    jaeseung-bae committed May 20, 2024
    Configuration menu
    Copy the full SHA
    99d5fbb View commit details
    Browse the repository at this point in the history

  2. Update grpc/src/main/java/com/linecorp/armeria/client/grpc/GrpcClient… 

    …Options.java

Co-authored-by: minux <songmw725@gmail.com>
    @jaeseung-bae @minwoox
    jaeseung-bae and minwoox committed May 20, 2024
    Configuration menu
    Copy the full SHA
    81c954d View commit details
    Browse the repository at this point in the history

  3. Update grpc/src/main/java/com/linecorp/armeria/internal/common/grpc/U… 

    …nwrappingGrpcExceptionHandleFunction.java

Co-authored-by: minux <songmw725@gmail.com>
    @jaeseung-bae @minwoox
    jaeseung-bae and minwoox committed May 20, 2024
    Configuration menu
    Copy the full SHA
    0cef19b View commit details
    Browse the repository at this point in the history