HttpService.orElse(HttpService) #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (nextSubHandler != null && res.status().code() == HttpResponseStatus.NOT_FOUND.code()) { | ||
| // The current sub-handler returned 404. Try the next sub-handler. | ||
| res.release(); | ||
| if (!promise.isDone()) { |
There was a problem hiding this comment.
Just wondering, when could this be true? Something like idle timeout?
There was a problem hiding this comment.
or unexpectedly closed connections.
trustin
force-pushed
the
better_404
branch
2 times, most recently
from
898beb9
to
2ebb99a
Compare
| invoke0(ctx, blockingTaskExecutor, promise, first, second); | ||
| } | ||
|
|
||
| private void invoke0(ServiceInvocationContext ctx, Executor blockingTaskExecutor, Promise<Object> promise, |
|
Found some longer lines... 😭 |
Motivation:
It is often useful to serve some resources in one HttpService and other
resources in the other HttpService. There's no way to bind such 2
services under the same path prefix.
Modifications:
- Add HttpService.orElse() so that a user can compose two HttpService
into one
- Test HttpService.orElse() using HttpFileServices
- Move the resources used by HttpFileServiceTest to an appropriate
directory
Result:
A user can combine two HttpServices:
virtualHost.serviceUnder(
"/foo",
HttpFileService.for(...).orElse(TomcatService.for(...)));
|
@delegacy Fixed :-) |
|
👍 Let's ship it. |
delegacy
added a commit
that referenced
this pull request
Dec 5, 2015
HttpService.orElse(HttpService)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It is often useful to serve some resources in one HttpService and other
resources in the other HttpService. There's no way to bind such 2
services under the same path prefix.
Modifications:
into one
directory
Result:
A user can combine two HttpServices: