Fix javadoc link and wrong tests

line · Aug 29, 2022 · 5a862e6 · 5a862e6
1 parent 61438e7
commit 5a862e6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/server/src/test/java/com/linecorp/centraldogma/server/RequestLogTest.java b/server/src/test/java/com/linecorp/centraldogma/server/RequestLogTest.java
@@ -106,7 +106,7 @@ void shouldLogRequests(RequestLogGroup logGroup, String path) throws Exception {
     @CsvSource({ "/api/v1/projects", "/monitor/l7check", "/monitor/metrics",
                  "/docs/index.html", "/styles/main.css" })
     @ParameterizedTest
-    void shouldAllLogRequests(String path) throws Exception {
+    void shouldLogAllRequests(String path) throws Exception {
         final CentralDogmaExtension dogmaExtension = newDogmaExtension(RequestLogGroup.ALL);
         final BlockingWebClient client = dogmaExtension.httpClient().blocking();
         setUp();
@@ -160,7 +160,7 @@ void noSamplingFailure() throws Exception {
     @CsvSource({ "API, /api/v1/projects", "HEALTH, /monitor/l7check", "METRICS, /monitor/metrics",
                  "DOCS, /docs/index.html", "WEB, /styles/main.css" })
     @ParameterizedTest
-    void shouldNotLogApiRequests(RequestLogGroup logGroup, String path) throws Exception {
+    void shouldNotLogTargetRequests(RequestLogGroup logGroup, String path) throws Exception {
         final RequestLogGroup[] logGroups =
                 Arrays.stream(RequestLogGroup.values())
                       .filter(group -> group != RequestLogGroup.ALL && group != logGroup)
@@ -175,7 +175,7 @@ void shouldNotLogApiRequests(RequestLogGroup logGroup, String path) throws Excep
                 .noneMatch(event -> {
                     return event.getLevel().equals(Level.DEBUG) &&
                            event.getMessage().contains("{} Request: {}") &&
-                           event.getFormattedMessage().contains("/api/v1/projects");
+                           event.getFormattedMessage().contains(path);
                 });
         dogmaExtension.stop();
     }

diff --git a/site/src/sphinx/setup-configuration.rst b/site/src/sphinx/setup-configuration.rst
@@ -239,12 +239,12 @@ Core properties
 
   - ``targetGroups`` (string array)
 
-     - the target :api:`RequestLogGroup`s which should be logged.
+     - the target :apiplural:`RequestLogGroup` which should be logged.
 
        - ``API`` - the services served under ``/api``
-       - ``METRICS` - the :api:`PrometheusExpositionService` served at ``/monitor/metrics``
-       - ``HEALTH` - the :api:`HealthCheckService` served at ``/monitor/l7check``
-       - ``DOCS` - the :api:`DocService` served under ``/docs``
+       - ``METRICS`` - the Prometheus exposition service served at ``/monitor/metrics``
+       - ``HEALTH`` - the health check service served at ``/monitor/l7check``
+       - ``DOCS`` - the documentation service served under ``/docs``
        - ``WEB`` - the static file services served under ``/web``, ``/vendor``, ``/scripts`` and ``/styles``.
        - ``ALL`` - the group that represents all groups.