Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to configure CORS policies #754

Closed
ikhoon opened this issue Nov 16, 2022 · 1 comment · Fixed by #811
Closed

Provide a way to configure CORS policies #754

ikhoon opened this issue Nov 16, 2022 · 1 comment · Fixed by #811
Labels
good first issue new feature

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Nov 16, 2022

so that web applications hosted in a different origin can call Central Dogma REST API.
@ikhoon ikhoon mentioned this issue Feb 21, 2023
Closed
16 tasks
@baont baont mentioned this issue Feb 23, 2023
Merged
@jrhee17
Copy link
Contributor

jrhee17 commented Mar 9, 2023

Relevant PR: #811

minwoox pushed a commit that referenced this issue Mar 16, 2023
@baont
Allow configuring CORS origins in config file (#811)
9fbb0b6 
This is my implementation for the issue #754.

Motivation
Provide a way to configure CORS policies, so that web applications hosted in a different origin can call Central Dogma REST API.

Modifications
- Add `corsAllowedOrigins` to `CentralDogmaConfig`
- Add Cors decorator when setting up HttpApi

Result:
- Close #754
- You can now configure CORS policies in the config file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow configuring CORS origins in config file baont/centraldogma
3 participants
@ikhoon @jrhee17 @minwoox