Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple Silicon binary for CLI #779

Closed
ikhoon opened this issue Dec 29, 2022 · 5 comments · Fixed by #831
Closed

Add Apple Silicon binary for CLI #779

ikhoon opened this issue Dec 29, 2022 · 5 comments · Fixed by #831
Milestone

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Dec 29, 2022

Currently, we only support amd64 for macOS CLI.
Go binaries are hosted in the release notes at https://github.com/line/centraldogma-go/releases/tag/0.0.1
We may build go CLI binaries for Apple Silicon and release it as 0.0.2

@ikhoon ikhoon added the defect label Dec 29, 2022
@ikhoon ikhoon added this to the 0.59.1 milestone Dec 29, 2022
@ikhoon ikhoon added improvement and removed defect labels Dec 29, 2022
@jrhee17 jrhee17 modified the milestones: 0.59.1, 0.60.0, 0.60.1, 0.60.2 Feb 9, 2023
@Dogacel
Copy link

Dogacel commented Mar 31, 2023

I am not sure if it is worth the effort but how about modifying the github actions workflow here to include github hosted m1 runners and publish the binaries as a part of the release workflow 😅

@ikhoon
Copy link
Contributor Author

ikhoon commented Apr 2, 2023

It is a good idea. centraldogma-go isn't actively developed since the API of Central Dogma is stable. That said, it would be worth automatically releasing the binaries with GitHub Actions.

@Dogacel
Copy link

Dogacel commented Apr 3, 2023

It is a good idea. centraldogma-go isn't actively developed since the API of Central Dogma is stable. That said, it would be worth automatically releasing the binaries with GitHub Actions.

If it is not actively developed, can I build it in my local and upload to at least provide a quick solution? Later a new issue can be opened regarding automated release pipeline?

@ikhoon
Copy link
Contributor Author

ikhoon commented Apr 7, 2023

I added a script that generates binaries for well-known architectures and operating systems.
line/centraldogma-go#60
As you said, we will automate the release pipeline if it is frequently updated.
Thanks for your interest and idea. 😃

ikhoon added a commit to ikhoon/centraldogma that referenced this issue Apr 7, 2023
@Dogacel
Copy link

Dogacel commented Apr 7, 2023

I added a script that generates binaries for well-known architectures and operating systems. line/centraldogma-go#60 As you said, we will automate the release pipeline if it is frequently updated. Thanks for your interest and idea. 😃

I did not know it was possible to compile for a specific architecture like that. I thought it was like iOS apps that need to be compiled on a Mac device 😆

Script looks good.

minwoox pushed a commit that referenced this issue Apr 7, 2023
trustin pushed a commit to line/centraldogma-go that referenced this issue May 10, 2023
… and operating systems (#60)

We don't build and publish Central Dogma binaries on a regular basis
yet. A build script and manual uploading would be sufficient at the
moment.

This will resolve the Apple silicon support in Central Dogma cli
line/centraldogma#779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants