Unwrap CompletionException to check actual thrown exception

[imasahiro]

Motivation:

• An exception which is thrown at CompletableFuture callback handler will be wrapped with CompletionException.
• ReplicationLagTolerantCentralDogma does not retry when CompletionException-wrapped RevisionNotFoundException is thrown

Changes:

• Unwrap CompletionException

Results:

• Handle replication lag correctly

[ikhoon]

Build error with Checkstyle 😉

> Task :client:java:checkstyleTest FAILED
[ant:checkstyle] [ERROR] /home/travis/build/line/centraldogma/client/java/src/test/java/com/linecorp/centraldogma/internal/client/ReplicationLagTolerantCentralDogmaTest.java:33:8: Unused import - java.util.concurrent.CountDownLatch. [UnusedImports]
[ant:checkstyle] [ERROR] /home/travis/build/line/centraldogma/client/java/src/test/java/com/linecorp/centraldogma/internal/client/ReplicationLagTolerantCentralDogmaTest.java:34:8: Unused import - java.util.concurrent.ExecutorService. [UnusedImports]
[ant:checkstyle] [ERROR] /home/travis/build/line/centraldogma/client/java/src/test/java/com/linecorp/centraldogma/internal/client/ReplicationLagTolerantCentralDogmaTest.java:37:8: Unused import - java.util.concurrent.TimeUnit. [UnusedImports]

[minwoox]

👍 Thanks!

[codecov]

Codecov Report

Merging #463 into master will increase coverage by 0.06%.
The diff coverage is 87.5%.

@@             Coverage Diff              @@
##             master     #463      +/-   ##
============================================
+ Coverage     69.87%   69.93%   +0.06%     
- Complexity     3108     3114       +6     
============================================
  Files           322      322              
  Lines         12569    12575       +6     
  Branches       1346     1347       +1     
============================================
+ Hits           8782     8794      +12     
+ Misses         2941     2937       -4     
+ Partials        846      844       -2

Impacted Files	Coverage Δ	Complexity Δ
...nal/client/ReplicationLagTolerantCentralDogma.java	87.55% <87.5%> (+1.54%)	85 <3> (+6)	⬆️
...ogma/client/armeria/CentralDogmaEndpointGroup.java	58.33% <0%> (-8.34%)	5% <0%> (-1%)
.../centraldogma/internal/client/AbstractWatcher.java	64.92% <0%> (-3.74%)	27% <0%> (-4%)
...internal/replication/ZooKeeperCommandExecutor.java	78.72% <0%> (+0.48%)	60% <0%> (ø)	⬇️
...com/linecorp/centraldogma/server/CentralDogma.java	75.55% <0%> (+0.48%)	47% <0%> (+1%)	⬆️
...r/internal/admin/auth/FileBasedSessionManager.java	77.69% <0%> (+1.43%)	25% <0%> (+1%)	⬆️
...corp/centraldogma/client/AbstractCentralDogma.java	55.17% <0%> (+3.44%)	12% <0%> (+1%)	⬆️
...com/linecorp/centraldogma/client/CentralDogma.java	55.55% <0%> (+11.11%)	8% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e6956...c082527. Read the comment docs.

[trustin]

Thanks a lot, @imasahiro !