Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Run git gc periodically (#564)" #615

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Revert "Run git gc periodically (#564)" #615

merged 1 commit into from
Jul 6, 2021

Conversation

minwoox
Copy link
Member

@minwoox minwoox commented Jul 6, 2021

Motivation:
We no longer need Git gc because we are going to provide a way to remove old commits.
#575

Modifications:

  • Revert Git gc.

Result:

@minwoox
Revert "Run git gc periodically (line#564)"
1b16d2e 
Motivation:
We no longer need Git gc because we are going to provide a way to remove old commits.
line#575

Modifications:
- Revert Git gc.

Result:
- This reverts commit e6caf26.
@minwoox minwoox added this to the 0.52.0 milestone Jul 6, 2021
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #615 (1b16d2e) into master (5108a8d) will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #615      +/-   ##
============================================
+ Coverage     70.24%   70.54%   +0.30%     
+ Complexity     3352     3321      -31     
============================================
  Files           336      333       -3     
  Lines         13359    13160     -199     
  Branches       1443     1418      -25     
============================================
- Hits           9384     9284     -100     
+ Misses         3082     2998      -84     
+ Partials        893      878      -15
Impacted Files Coverage Δ
...ecorp/centraldogma/server/CentralDogmaBuilder.java 53.96% <ø> (+1.66%) ⬆️
...internal/storage/repository/RepositoryWrapper.java 31.25% <ø> (+1.83%) ⬆️
...al/storage/repository/cache/CachingRepository.java 89.31% <ø> (+1.34%) ⬆️
...raldogma/server/storage/repository/Repository.java 67.25% <ø> (ø)
...necorp/centraldogma/server/CentralDogmaConfig.java 80.68% <100.00%> (-0.27%) ⬇️
...internal/storage/repository/git/GitRepository.java 80.57% <100.00%> (+1.29%) ⬆️
...ogma/client/armeria/CentralDogmaEndpointGroup.java 57.69% <0.00%> (-7.70%) ⬇️
.../centraldogma/internal/client/AbstractWatcher.java 77.93% <0.00%> (-1.38%) ⬇️
...com/linecorp/centraldogma/server/CentralDogma.java 77.33% <0.00%> (+0.46%) ⬆️
...centraldogma/server/internal/api/WatchService.java 76.27% <0.00%> (+3.38%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5108a8d...1b16d2e. Read the comment docs.

ikhoon
ikhoon approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋👋👋

@minwoox minwoox merged commit c8fc35a into line:master Jul 6, 2021
@minwoox minwoox deleted the revertGc branch July 6, 2021 05:22
@minwoox
Copy link
Member Author

minwoox commented Jul 6, 2021

Thanks for reviewing. 😉

@ikhoon ikhoon mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikhoon ikhoon ikhoon approved these changes

@trustin trustin Awaiting requested review from trustin

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
0.52.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minwoox @ikhoon