Add credential method to access GitHub with Personal Access Token #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
taiga-nada
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #813 +/- ##
============================================
- Coverage 65.74% 65.66% -0.08%
+ Complexity 3291 3289 -2
============================================
Files 350 351 +1
Lines 13731 13751 +20
Branches 1488 1491 +3
============================================
+ Hits 9027 9030 +3
- Misses 3862 3872 +10
- Partials 842 849 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
trustin
reviewed
Feb 27, 2023
There was a problem hiding this comment.
So far so good! Could you continue to:
- Add documentation; and
- Update GitMirrorAuthTest so we can test access-token-based authentication manually? (I already gave you the read permission to the private test repository.)
|
@taiga-nada will send a follow-up PR that updates |
|
I updated documentations. |
trustin
approved these changes
Mar 3, 2023
ikhoon
approved these changes
Mar 3, 2023
jrhee17
approved these changes
Mar 3, 2023
trustin
pushed a commit
that referenced
this pull request
Mar 13, 2023
…t` (#820) Motivation: We want to verify access token credential using [GitHub Personal Access Token (PAT)](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token). Modifications: - Added test codes for GitHub Personal Access Token into `GitMirrorAuthTest` Related: - We can do auth test with access token (relates to: #813)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It'd be nice if a user can use GitHub Personal Access Token (PAT) to mirror a GitHub repository.
Modifications:
AccessTokenMirrorCredentialto access a GitHub repository with PAT.Result: