Migrate Docker registry from Docker Hub to GitHub container registry #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Although Docker decided to [revert sunset the “Docker Free Team” plan](https://www.docker.com/blog/we-apologize-we-did-a-terrible-job-announcing-the-end-of-docker-free-teams/), we still think it is worth migrating our container registry to GitHub. Because users will easily checkout the images on our GitHub repository. Modifications: - Fixed to publish docker images to `ghcr.io` Result: You can now get Central Dogma docker images from `ghrc.io` ``` docker pull ghrc.io/line/centraldogma:latest ```
subrepo: subdir: "gradle/scripts" merged: "966b563a" upstream: origin: "https://github.com/line/gradle-scripts.git" branch: "main" commit: "966b563a" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "dbb99be"
|
https://github.com/ikhoon/centraldogma/pkgs/container/centraldogma This is an example registry that was created by this change. |
|
@KarboniteKream I think this change will affect your test environment. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
============================================
+ Coverage 65.61% 65.64% +0.02%
- Complexity 3319 3321 +2
============================================
Files 355 355
Lines 13865 13865
Branches 1498 1498
============================================
+ Hits 9098 9101 +3
+ Misses 3916 3913 -3
Partials 851 851 see 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jrhee17
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Although Docker decided to revert sunset the “Docker Free Team” plan,
we still think it is worth migrating our container registry to GitHub.
Because users will easily check out the images on our GitHub repository.
Modifications:
ghcr.ioResult:
ghrc.io