Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Armeria version to 1.27.2 #924

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Update Armeria version to 1.27.2 #924

merged 1 commit into from
Feb 26, 2024

Conversation

armerian
Copy link
Contributor

No description provided.

@jrhee17 jrhee17 added this to the 0.64.3 milestone Feb 26, 2024
@ikhoon
Copy link
Contributor

ikhoon commented Feb 26, 2024

A problem occurred configuring project ':testing:testing-common'.
> Could not resolve all files for configuration ':common:shadedJarTestRuntime'.
   > Could not find com.linecorp.armeria:armeria-thrift0.9:1.27.2.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/com/linecorp/armeria/armeria-thrift0.9/1.27.2/armeria-thrift0.9-1.27.2.pom

armeria-bom was published but armeria-thrift0.9 hasn't been published yet. 😅
https://repo.maven.apache.org/maven2/com/linecorp/armeria/armeria-bom/1.27.2/armeria-bom-1.27.2.pom
https://repo.maven.apache.org/maven2/com/linecorp/armeria/armeria-thrift0.9/1.27.2/armeria-thrift0.9-1.27.2.pom

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.80%. Comparing base (a5eb412) to head (e469868).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #924      +/-   ##
============================================
+ Coverage     66.77%   66.80%   +0.02%     
+ Complexity     3514     3513       -1     
============================================
  Files           370      370              
  Lines         14476    14476              
  Branches       1553     1553              
============================================
+ Hits           9667     9671       +4     
+ Misses         3932     3928       -4     
  Partials        877      877              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrhee17
Copy link
Contributor

jrhee17 commented Feb 26, 2024

armeria-bom was published but armeria-thrift0.9 hasn't been published yet. 😅

Thanks for the analysis 👍 I guess just listing all Armeria versions we depend on makes sense (since the list doesn't change very often)

Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️ 🏎️ 🏎️

@jrhee17 jrhee17 merged commit 1690342 into main Feb 26, 2024
11 checks passed
@jrhee17 jrhee17 deleted the update-armeria-version branch February 26, 2024 06:19
@ikhoon
Copy link
Contributor

ikhoon commented Feb 26, 2024

I guess just listing all Armeria versions we depend on makes sense

Good idea. Let me send a fix PR before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants