Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky ServerStatusManagerIntegrationTest #948

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Fix flaky ServerStatusManagerIntegrationTest #948

merged 2 commits into from
Apr 23, 2024

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Apr 23, 2024 •
edited
Loading

Motivation:

ServerStatusManagerIntegrationTest reuses the acquired ports to restart the running cluster. I observed that the ports were not released after cluster.stop().

image

Modifications:

  • Sleep 3 seconds after a cluster stop to give enough time to release the ports.

Result:

Fixes CI failures.

@ikhoon ikhoon added the cleanup label Apr 23, 2024
@ikhoon ikhoon added this to the 0.65.0 milestone Apr 23, 2024
@ikhoon ikhoon marked this pull request as ready for review April 23, 2024 07:02
minwoox
minwoox approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍 👍 👍

@minwoox minwoox merged commit 9550282 into line:main Apr 23, 2024
9 checks passed
ikhoon added a commit to ikhoon/centraldogma that referenced this pull request Apr 23, 2024
@ikhoon
Fix flaky ServerStatusManagerIntegrationTest (2)
7d9a211 
Motivation:

This PR tries to solve the flakiness of `ServerStatusManagerIntegrationTest`
in a different way. See line#948

This workaround minimizes port collisions by ensuring that all ports are
available when a Central Dogma cluster starts.

Modifications:

- Check if all ports are open when restarting
  `CentralDogmaReplicationExtension`.

Result:

Less flakiness
@ikhoon ikhoon mentioned this pull request Apr 23, 2024
Merged
trustin pushed a commit that referenced this pull request Jun 21, 2024
@ikhoon
Fix flaky ServerStatusManagerIntegrationTest (2) (#949)
87f5ae0 
Motivation:

This PR tries to solve the flakiness of
`ServerStatusManagerIntegrationTest` in a different way. See #948

This workaround minimizes port collisions by ensuring that all ports are
available when a Central Dogma cluster starts.

Modifications:

- Check if all ports are open when restarting
`CentralDogmaReplicationExtension`.

Result:

Less flakiness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minwoox minwoox minwoox approved these changes

@trustin trustin Awaiting requested review from trustin trustin is a code owner

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
0.65.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ikhoon @minwoox