Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Images are uploaded but dont show up in page #5

Closed
nickv9 opened this issue Feb 15, 2019 · 4 comments · Fixed by #7
Closed

Images are uploaded but dont show up in page #5

nickv9 opened this issue Feb 15, 2019 · 4 comments · Fixed by #7
Labels
bug Something isn't working

Comments

@nickv9
Copy link

nickv9 commented Feb 15, 2019

I am using knitr::include_graphics() with .png files to include graphics in the confluence page. The images are uploaded but don't show up in the page. I am able to manually edit the page to put the images in without having to re-upload them.

@yutannihilation
Copy link
Contributor

Thanks for the report! Probably, it's because include_graphics() generates a different img tag than the expected here. Will fix.

'<img src="[^"]*/([^"/]+?)" alt="[^"]*"/>',

@yutannihilation
Copy link
Contributor

@nickv9 This should work now. Could you reinstall and test the latest conflr when you have time?

Note that previewing knitr::include_graphics() is currently broken... Please ignore this for now, published documents should be fine.

@yutannihilation yutannihilation added the bug Something isn't working label Feb 18, 2019
@nickv9
Copy link
Author

nickv9 commented Feb 20, 2019

@yutannihilation Yutani-san - this worked , thank you so much!

This is a great package - it is REALLY useful for me!

@yutannihilation
Copy link
Contributor

@nickv9 Thanks for confirming! Glad to hear that 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants