Prepare Gradle 9.0 deprecations #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Starting with Gradle 9.0, Gradle will not run builds if a project directory is missing or read-only. (ref: https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#deprecated_missing_project_directory) Modification: - Create project directories Result: - Deprecation for Gradle 9.0 is prepared for this behavior
|
|
sh-cho
changed the title
sh-cho
force-pushed
the
gradle-missing-project-dir
branch
from
fdaf11d
to
8b7893a
Compare
minwoox
approved these changes
May 20, 2024
The `AbstractArchiveTask.archivePath` property has been deprecated. This is scheduled to be removed in Gradle 9.0. https://docs.gradle.org/8.7/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html
sh-cho
changed the title
|
@sh-cho Thanks! 😄 |
trustin
reviewed
Jun 5, 2024
| relocatedProjects.each { | ||
| if (it != project && !it.hasFlags('no_aggregation')) { | ||
| injars it.tasks.shadedJar.archivePath | ||
| injars it.tasks.shadedTestJar.archivePath | ||
| injars it.tasks.shadedJar.aarchiveFile.get().asFile |
minwoox
pushed a commit
to line/armeria
that referenced
this pull request
Jun 11, 2024
Motivation: Starting with Gradle 9.0, Gradle will not run builds if a project directory is missing or read-only. (ref: https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#deprecated_missing_project_directory) Modification: - Create project directories under `build/virtual-projects` - `:bom`, `:version-catalog` - `:dependencyManagement` will be handled via line/gradle-scripts#177 Result: - Deprecation for Gradle 9.0 is prepared for this behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Prepare deprecations which will be removed or fail in Gradle 9.0
Modification:
build/virtual-projects. Starting 9.0, Gradle will not run builds if a project directory is missing or read-only. (https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#deprecated_missing_project_directory)base { }(https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#base_convention_deprecation)AbstractArchiveTask.archivePathwitharchiveFile(https://docs.gradle.org/8.7/javadoc/org/gradle/api/tasks/bundling/AbstractArchiveTask.html#getArchivePath--)Result: