-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add String functions(concat) #545
Add String functions(concat) #545
Conversation
value1: String, | ||
value2: String, | ||
vararg others: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The String parameter should probably be nullable. When I tested it, both eclipselink and hibernate returned a blank character if null was passed in.
Users can take advantage of this functionality, so I don't think we should prevent it.
String 파라미터는 nullable이여야 할 것 같아요. 테스트 해보니 eclipselink 및 hibernate 모두 null이면 공백 문자를 반환해주었습니다.
사용자가 이 기능을 활용할 수 있기 때문에 저희가 막으면 안 될 것 같아요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String 파라미터는 nullable이여야 할 것 같아요. 테스트 해보니 eclipselink 및 hibernate 모두 null이면 공백 문자를 반환해주었습니다.
사용자가 이 기능을 활용할 수 있기 때문에 저희가 막으면 안 될 것 같아요.
그럼 말씀하신 케이스 고려해서 아래처럼 default value는 없이 변경하겠습니다.
fun concat(
value1: String?,
value2: String?,
vararg others: String?,
): Expression<String> {
return Expressions.concat(
Expressions.value(value1),
Expressions.value(value2),
others.map { Expressions.value(it) },
)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵! 감사합니다. ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shouwn
리뷰 반영했습니다!
8b5f402
to
bb6c025
Compare
Motivation
Modifications
Commit Convention Rule
commit type
please describe it on the Pull RequestResult
Closes