Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Flex Message Update 2 #234

Closed
tkgauri opened this issue Oct 12, 2020 · 9 comments · Fixed by #235, #236, #253 or #269
Closed

Support Flex Message Update 2 #234

tkgauri opened this issue Oct 12, 2020 · 9 comments · Fixed by #235, #236, #253 or #269
Assignees

Comments

@tokuhirom
Copy link
Member

@kkdai, which checkboxes are not implemented yet? Have you implemented all the features? If so, close the Issue.

@kkdai kkdai linked a pull request Feb 23, 2021 that will close this issue
@kkdai
Copy link
Member

kkdai commented Feb 23, 2021

@tokuhirom Thank you for reminding me, I will review the current status and check with PR #253

@kkdai
Copy link
Member

kkdai commented Feb 24, 2021

2, 5, 7 are fixed by #253

@kkdai kkdai reopened this Feb 24, 2021
@kkdai
Copy link
Member

kkdai commented Feb 24, 2021

Hi @hinoguma,
Is it possible to help on items 1, 3, 4, and 6?
I will help you to review, thank you.

@kkdai
Copy link
Member

kkdai commented Feb 24, 2021

item 8 has been completed.

@hinoguma
Copy link
Contributor

hinoguma commented Feb 24, 2021

@kkdai

Is it possible to help on items 1, 3, 4, and 6?

OK!
I'll do them as soon as I can, but might take a few days.

@hinoguma
Copy link
Contributor

@kkdai
we don't need to do anything below.
I think we can put a check mark.

1, Changed the maximum number of bubbles that can be included in a carousel
Mx number validation is sdk-user's responsibility.
This sdk do not validate maximum number of template message actions and so on.

4, Allowed an empty array to be specified as the value of a box's contents property
We've tested this case yet.

{
JSON: []byte(`{
"type": "bubble",
"body": {
"type": "box",
"layout": "vertical",
"contents": [
{
"type": "image",
"url": "https://example.com/flex/images/image.jpg",
"animated": true
},
{
"type": "separator"
},
{
"type": "text",
"text": "Text in the box",
"adjustMode": "shrink-to-fit"
},
{
"type": "box",
"layout": "vertical",
"contents": [],
"width": "30px",
"height": "30px"
}
],
"height": "400px",
"justifyContent": "space-evenly",
"alignItems": "center"
}
}`),
Want: &BubbleContainer{
Type: FlexContainerTypeBubble,
Body: &BoxComponent{
Type: FlexComponentTypeBox,
Layout: FlexBoxLayoutTypeVertical,
Contents: []FlexComponent{
&ImageComponent{
Type: FlexComponentTypeImage,
URL: "https://example.com/flex/images/image.jpg",
Animated: true,
},
&SeparatorComponent{
Type: FlexComponentTypeSeparator,
},
&TextComponent{
Type: FlexComponentTypeText,
Text: "Text in the box",
AdjustMode: FlexComponentAdjustModeTypeShrinkToFit,
},
&BoxComponent{
Type: FlexComponentTypeBox,
Layout: FlexBoxLayoutTypeVertical,
Contents: []FlexComponent{},
Width: "30px",
Height: "30px",
},
},
Height: "400px",
JustifyContent: FlexComponentJustifyContentTypeSpaceEvenly,
AlignItems: FlexComponentAlignItemsTypeCenter,
},
},
},
}

6, Changed how sizes are specified
 Image component

type FlexImageSizeType string exists.

@kkdai kkdai linked a pull request Mar 29, 2021 that will close this issue
@kkdai
Copy link
Member

kkdai commented Mar 29, 2021

#269 for 3

@kkdai
Copy link
Member

kkdai commented Mar 29, 2021

@kkdai
we don't need to do anything below.
I think we can put a check mark.

1, Changed the maximum number of bubbles that can be included in a carousel
Mx number validation is sdk-user's responsibility.
This sdk do not validate maximum number of template message actions and so on.

4, Allowed an empty array to be specified as the value of a box's contents property
We've tested this case yet.

{
JSON: []byte(`{
"type": "bubble",
"body": {
"type": "box",
"layout": "vertical",
"contents": [
{
"type": "image",
"url": "https://example.com/flex/images/image.jpg",
"animated": true
},
{
"type": "separator"
},
{
"type": "text",
"text": "Text in the box",
"adjustMode": "shrink-to-fit"
},
{
"type": "box",
"layout": "vertical",
"contents": [],
"width": "30px",
"height": "30px"
}
],
"height": "400px",
"justifyContent": "space-evenly",
"alignItems": "center"
}
}`),
Want: &BubbleContainer{
Type: FlexContainerTypeBubble,
Body: &BoxComponent{
Type: FlexComponentTypeBox,
Layout: FlexBoxLayoutTypeVertical,
Contents: []FlexComponent{
&ImageComponent{
Type: FlexComponentTypeImage,
URL: "https://example.com/flex/images/image.jpg",
Animated: true,
},
&SeparatorComponent{
Type: FlexComponentTypeSeparator,
},
&TextComponent{
Type: FlexComponentTypeText,
Text: "Text in the box",
AdjustMode: FlexComponentAdjustModeTypeShrinkToFit,
},
&BoxComponent{
Type: FlexComponentTypeBox,
Layout: FlexBoxLayoutTypeVertical,
Contents: []FlexComponent{},
Width: "30px",
Height: "30px",
},
},
Height: "400px",
JustifyContent: FlexComponentJustifyContentTypeSpaceEvenly,
AlignItems: FlexComponentAlignItemsTypeCenter,
},
},
},
}

6, Changed how sizes are specified
 Image component

type FlexImageSizeType string exists.

Confirmed 1, 4, 6 fixed already. Mark this issue as close.
Thank you @hinoguma

@kkdai kkdai closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment