Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New LIFF API and Flex Message API PR Code Review #84

Closed
justdomepaul opened this issue Jun 26, 2018 · 3 comments
Closed

New LIFF API and Flex Message API PR Code Review #84

justdomepaul opened this issue Jun 26, 2018 · 3 comments

Comments

@justdomepaul
Copy link
Contributor

#83

I PR a latest version, please code review and merge to master.

Thanks.

@sugyan
Copy link
Contributor

sugyan commented Jun 26, 2018

Thanks for your contribution!
I have some comments...

  • Please use gofmt. Align the indents and use tab instead of spaces.
  • Since "Flex messages" and "LIFF" are different functions, we want pull-requests to be separated.
  • .gitignore for files not related to Go language should be set by each developer in git config --global core.excludesfile etc. It should not be included in pull-request.

@justdomepaul
Copy link
Contributor Author

justdomepaul commented Jun 26, 2018

@sugyan

Thanks for your feedback!

I will handle some point.

  • fmt all changed go file
  • new two branch to separeate "Flex Messages" and "LIFF" function to different PR.
  • recovery origin .gitignore file

ps. I think your "Flex Messages" solution is better than my solution. It is a good point to solve complex struct of "Flex Messages".

@sugyan
Copy link
Contributor

sugyan commented Jul 10, 2018

This has been updated by #89, so I close it.

@sugyan sugyan closed this as completed Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants