Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithHttpInfo method #731

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Conversation

tokuhirom
Copy link
Member

This PR is based on #730

Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you for adding this 🙇

Comment on lines +73 to +79
return (
await this.getsAllValidChannelAccessTokenKeyIdsWithHttpInfo(
clientAssertionType,
clientAssertion,
)
)[1];
}
Copy link
Contributor

@Yang-33 Yang-33 Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const [rawResponse, body] = await this.getsAllValidChannelAccessTokenKeyIdsWithHttpInfo(
        clientAssertionType,
        clientAssertion,
      )
return body

could be a little bit better than return (...)[1]...? (although I guess introducing another type is much better)

@tokuhirom tokuhirom enabled auto-merge (squash) March 1, 2024 09:40
@tokuhirom tokuhirom merged commit 7acd9ee into line:master Mar 1, 2024
3 checks passed
@tokuhirom tokuhirom deleted the fetch-with-http-info branch March 1, 2024 09:41
@Yang-33 Yang-33 linked an issue Mar 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fetch() function instead of axios
2 participants