Skip to content

Commit

Permalink
Cleanup development environments
Browse files Browse the repository at this point in the history
  • Loading branch information
Satoru Yoshihara committed Dec 27, 2017
1 parent 2f5894a commit 1ab07a9
Show file tree
Hide file tree
Showing 5 changed files with 49 additions and 44 deletions.
3 changes: 1 addition & 2 deletions .travis.yml
Expand Up @@ -7,6 +7,5 @@ php:
- '7.1'
install:
- composer update
script: ./vendor/bin/phpunit ./tests
script: composer test
sudo: false

55 changes: 13 additions & 42 deletions Makefile
@@ -1,57 +1,21 @@
COMPOSER_BIN = ./vendor/bin

.PHONY: default test doc phpcs phpmd check install-devtool copyright release
.PHONY: default test doc phpcs phpmd check install-devtool copyright release clean install reinstall

default: check

test:
$(COMPOSER_BIN)/phpunit ./tests
composer test

doc:
yes yes | $(COMPOSER_BIN)/apigen generate --source=./src --destination=./docs --title line-bot-sdk-php
composer doc

phpcs:
$(COMPOSER_BIN)/phpcs --standard=PSR2 src/ tests/ examples/EchoBot/src examples/EchoBot/public examples/KitchenSink/src examples/KitchenSink/public
composer cs

phpmd:
$(COMPOSER_BIN)/phpmd ./src text cleancode,codesize,controversial,design,unusedcode,naming | \
grep -v 'Avoid using static access to class' | \
grep -v 'Avoid variables with short names like' | \
grep -v 'Avoid excessively long variable names like' | \
grep -v 'The method register uses an else expression' | \
grep -v 'The method sendRequest uses an else expression' | \
cat
$(COMPOSER_BIN)/phpmd ./examples/EchoBot/src text cleancode,codesize,controversial,design,unusedcode,naming | \
grep -v 'Avoid using static access to class' | \
grep -v 'Avoid variables with short names like' | \
grep -v 'Avoid excessively long variable names like' | \
grep -v 'The method register uses an else expression' | \
grep -v 'The method sendRequest uses an else expression' | \
cat
$(COMPOSER_BIN)/phpmd ./examples/EchoBot/public text cleancode,codesize,controversial,design,unusedcode,naming | \
grep -v 'Avoid using static access to class' | \
grep -v 'Avoid variables with short names like' | \
grep -v 'Avoid excessively long variable names like' | \
grep -v 'The method register uses an else expression' | \
grep -v 'The method sendRequest uses an else expression' | \
cat
$(COMPOSER_BIN)/phpmd ./examples/KitchenSink/src text cleancode,codesize,controversial,design,unusedcode,naming | \
grep -v 'Avoid using static access to class' | \
grep -v 'Avoid variables with short names like' | \
grep -v 'Avoid excessively long variable names like' | \
grep -v 'The method register uses an else expression' | \
grep -v 'The method sendRequest uses an else expression' | \
cat
$(COMPOSER_BIN)/phpmd ./examples/KitchenSink/public text cleancode,codesize,controversial,design,unusedcode,naming | \
grep -v 'Avoid using static access to class' | \
grep -v 'Avoid variables with short names like' | \
grep -v 'Avoid excessively long variable names like' | \
grep -v 'The method register uses an else expression' | \
grep -v 'The method sendRequest uses an else expression' | \
cat
composer md

copyright:
bash ./devtool/check_copyright.sh
devtool/check_copyright.sh

check: test copyright phpcs phpmd

Expand All @@ -68,3 +32,10 @@ endif
git tag $(VERSION)
git push origin $(VERSION)

clean:
rm -rf vendor composer.lock

install:
composer install

reinstall: clean install
6 changes: 6 additions & 0 deletions composer.json
Expand Up @@ -38,5 +38,11 @@
"psr-4": {
"LINE\\Tests\\": "tests/"
}
},
"scripts": {
"test": "phpunit tests",
"doc": "apigen generate --source=src --destination=docs --title line-bot-sdk-php",
"cs": "phpcs --standard=PSR2 src tests examples/EchoBot/src examples/EchoBot/public examples/KitchenSink/src examples/KitchenSink/public",
"md": "phpmd --ignore-violations-on-exit src,examples/EchoBot/src,examples/EchoBot/public,examples/KitchenSink/src,examples/KitchenSink/public text phpmd.xml"
}
}
Empty file modified devtool/check_copyright.sh 100644 → 100755
Empty file.
29 changes: 29 additions & 0 deletions phpmd.xml
@@ -0,0 +1,29 @@
<?xml version="1.0"?>
<ruleset name="My first PHPMD rule set" xmlns="http://pmd.sf.net/ruleset/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0http://pmd.sf.net/ruleset_xml_schema.xsd"
xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">

<description>line-bot-sdk-php phpmd custom rules</description>

<exclude-pattern>KitchenSink/Route.php</exclude-pattern>

<rule ref="rulesets/cleancode.xml">
<exclude name="ElseExpression" />
<exclude name="StaticAccess" />
</rule>

<rule ref="rulesets/codesize.xml" />

<rule ref="rulesets/controversial.xml">
<exclude name="Superglobals" />
</rule>

<rule ref="rulesets/design.xml" />
<rule ref="rulesets/unusedcode.xml" />

<rule ref="rulesets/naming.xml">
<exclude name="ShortVariable" />
<exclude name="LongVariable" />
</rule>
</ruleset>

0 comments on commit 1ab07a9

Please sign in to comment.