Skip to content

Commit

Permalink
Replace old liff functions with new ones and keep backward compatibil…
Browse files Browse the repository at this point in the history
…ity (#486)

* NO-ISSUE Revert "chore(deps): update dependency black to v23.7.0 (#483)"

This reverts commit 4f5bf2b.

* NO-ISSUE apply latest liff-operation-id

* NO-ISSUE test

* NO-ISSUE Modify script

* NO-ISSUE Update line-openapi

* NO-ISSUE Keep old functions by calling new functions for backward compatibility

* NO-ISSUE Add comment
  • Loading branch information
Yang-33 committed Jul 24, 2023
1 parent 69f937b commit 7166a75
Show file tree
Hide file tree
Showing 6 changed files with 354 additions and 246 deletions.
24 changes: 24 additions & 0 deletions generate-code.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,25 @@ def run_command(command):
output = subprocess.check_output(command, shell=True)
return output.decode('utf-8').strip()


def rewrite_liff_function_name_backward_compats():
for fname in ['liff.py', 'async_liff.py']:
with open(f'linebot/v3/liff/api/{fname}', 'a') as fp:
fp.write("\n\n")
for (orig, cur) in [('liff_v1_apps_get', 'get_all_liff_apps'),
('liff_v1_apps_get_with_http_info', 'get_all_liff_apps_with_http_info'),
('liff_v1_apps_post', 'add_liff_app'),
('liff_v1_apps_post_with_http_info', 'add_liff_app_with_http_info'),
('liff_v1_apps_liff_id_put', 'update_liff_app'),
('liff_v1_apps_liff_id_put_with_http_info', 'update_liff_app_with_http_info'),
('liff_v1_apps_liff_id_delete', 'delete_liff_app'),
('liff_v1_apps_liff_id_delete_with_http_info', 'delete_liff_app_with_http_info')]:
fp.write(f"\n")
fp.write(f" def {orig}(self, *args, **kwargs):\n")
fp.write(f" import warnings\n")
fp.write(f" warnings.warn('{orig} was deprecated. use {cur} instead.', DeprecationWarning)\n")
fp.write(f" return self.{cur}(*args, **kwargs)\n")

def main():

os.chdir("generator")
Expand Down Expand Up @@ -68,5 +87,10 @@ def main():
'''
run_command(command)


## TODO(v4): Delete this workaround in v4. This workaround keeps backward compatibility.
rewrite_liff_function_name_backward_compats()


if __name__ == "__main__":
main()
2 changes: 1 addition & 1 deletion line-openapi
Submodule line-openapi updated 1 files
+6 −12 liff.yml

0 comments on commit 7166a75

Please sign in to comment.