Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validating message objects APIs #409

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Oct 28, 2022

Resolve #408

@Yang-33
Copy link
Contributor Author

Yang-33 commented Oct 28, 2022

CI failure will be fixed in #410

@Yang-33 Yang-33 marked this pull request as ready for review October 28, 2022 17:33
@Yang-33
Copy link
Contributor Author

Yang-33 commented Nov 24, 2022

@louis70109 could you take a look please?

@louis70109
Copy link
Member

@louis70109 could you take a look please?

@Yang-33 I leave a few messages in review, please check~

@Yang-33
Copy link
Contributor Author

Yang-33 commented Dec 29, 2022

@louis70109 probably you forgot submitting review comments. Could you check please? I can't find any messages...

linebot/api.py Show resolved Hide resolved
Comment on lines +398 to +399
return ValidatePushMessageObjectsResponse(
request_id=response.headers.get('X-Line-Request-Id'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. 🆙

linebot/api.py Show resolved Hide resolved
linebot/api.py Show resolved Hide resolved
linebot/api.py Show resolved Hide resolved
linebot/async_api.py Show resolved Hide resolved
linebot/async_api.py Show resolved Hide resolved
linebot/async_api.py Show resolved Hide resolved
linebot/async_api.py Show resolved Hide resolved
linebot/api.py Show resolved Hide resolved
@louis70109
Copy link
Member

@louis70109 could you take a look please?

@Yang-33 oh so sorry, thanks notification!

Copy link
Member

@louis70109 louis70109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Big thanks to @Yang-33 😍

@louis70109 louis70109 merged commit c950e25 into line:master Feb 10, 2023
@Yang-33 Yang-33 mentioned this pull request Mar 13, 2023
@Yang-33 Yang-33 deleted the validate-messages-python branch May 4, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validating message objects
2 participants