Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rich menu sample code #241

Merged
merged 1 commit into from Nov 10, 2021
Merged

add rich menu sample code #241

merged 1 commit into from Nov 10, 2021

Conversation

4geru
Copy link
Contributor

@4geru 4geru commented Oct 28, 2021

Rich menu support has been completed in ruby, so replaced the official sample code with ruby.
https://developers.line.biz/en/docs/messaging-api/using-rich-menus/

toduq
toduq approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@toduq toduq left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

../public/richmenu-a.png and ../public/richmenu-b.png seems to be not found on this repository, however, LGTM.

Oh, it was attached. Sorry for that.

toduq
toduq reviewed Oct 29, 2021
View reviewed changes
Copy link
Contributor

@toduq toduq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some typos. Could you kindly check and fix them?

examples/rich_menu/app.rb Show resolved Hide resolved
examples/rich_menu/app.rb Outdated Show resolved Hide resolved
examples/rich_menu/app.rb Outdated Show resolved Hide resolved
examples/rich_menu/app.rb Outdated Show resolved Hide resolved
@4geru
Copy link
Contributor Author

4geru commented Oct 29, 2021

sorry i fixed movable code. and other project like nodejs, python are written README.md so added.

 → bundle exec ruby app.rb
created: {"richMenuId"=>"richmenu-7a1e0cb0da3139f5320c443d43db85d2"}
created: {"richMenuId"=>"richmenu-3325000b4738c42edd06f939d55ca36d"}
success

toduq
toduq approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@toduq toduq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected. LGTM, again.

@4geru
Copy link
Contributor Author

4geru commented Nov 10, 2021

@kimoto plz rereview 🙇

@kimoto
Copy link
Contributor

kimoto commented Nov 10, 2021

LGTM!
Sorry for the late reply.

@kimoto kimoto merged commit 7fd7121 into line:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimoto kimoto kimoto approved these changes

@toduq toduq toduq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@4geru @kimoto @toduq