UserKeyServiceImpl convert function does not support EdDSA Algorithm #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kj84park
approved these changes
Sep 24, 2021
|
LGTM! Thank you for your contribution! |
|
For merging, could you sign the CLA? |
|
hey there, thanks for your review. I have signed the CLA thru the website the github bot links, but the github bot doesn't seem to recognise/update? When I click on the link now I get "You have agreed to the CLA for line/line-fido2-server". Is there anything I can do to update the bot? |
|
ah whoops! i'd made a commit from another account and had to sign with both. all fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#What is this PR for?
See Issue #4
Overview or reasons
Please see Issue #4
Tasks
Result