Use ActivityResultContracts as onActivityResult is deprecated

[bhbac-nhnent]

Is it a security issue?

• No

What did you do?

• Integrating LINE Login.

What did you expect?

• Do not appear 'deprecated' warning

What happened actually?

• Line Android SDK needs to override 'onActivityResult'.
  • https://developers.line.biz/en/docs/line-login-sdks/android-sdk/integrate-line-login/#handling-login-result
• But 'onActivityResult' is deprecated API.
• The android development environment no longer recommends that developers call the onActivityResult API.

Your environment?

• Normal Android development environment.

Sample project

• Just create new Android project from Android Studio and write 'onActivityResult' override function in Activity class.
  • 

How to fix

• The Facebook Android SDK is a good example.
• They had a same issue and they fixed it.
  • Use ActivityResultContracts as onActivityResult is deprecated facebook/facebook-android-sdk#875
  • facebook/facebook-android-sdk@b48ac0d
• Now they guide the user to:

  If you are using AndroidX activities or fragments, you don't have to override onActivityResult.

  • https://developers.facebook.com/docs/facebook-login/android?locale=en_US#9--register-a-callback

[vincent-paing]

I read the docs and seems like you don't need to override onActivityResult if you use the login button they provide out of the box. But for customized solution, you would need to. My 2 cent is this should be part of the code sdk since the API is already extensible but changing to contract would limit the extensibility.

Implementing this in ActivityResultContract seems fairly simple. Here's the code that I wrote if you want to use in your app. I also submitted a PR just in case maintainers want to make this part of core sdk