Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some English errors #20

Merged
merged 1 commit into from Jun 12, 2019
Merged

Fix some English errors #20

merged 1 commit into from Jun 12, 2019

Conversation

wouter-veeken
Copy link
Contributor

Fixed some grammar and style issues in code comments.

Fixed some grammar and style issues in comments.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Wouter Veeken seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@plateaukao plateaukao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plateaukao plateaukao merged commit ebbd72a into line:master Jun 12, 2019
plateaukao pushed a commit to plateaukao/line-sdk-android that referenced this pull request Oct 21, 2019
…ranch (line#12)

* support "amr" in id_token

* new feature: add a new param to set the login pages language (line#16)

* Fix English (line#20)

Fixed some grammar and style issues in comments.

* update version to 5.1

* config travis build (line#24)

* IMPROVE: get expected `IdToken.Issuer` from OpenId Discovery Document (line#26)
plateaukao pushed a commit to plateaukao/line-sdk-android that referenced this pull request Oct 21, 2019
* NO-ISSUE Internal repo master branch rebase open source repo master branch (line#12)

* support "amr" in id_token

* new feature: add a new param to set the login pages language (line#16)

* Fix English (line#20)

Fixed some grammar and style issues in comments.

* update version to 5.1

* config travis build (line#24)

* IMPROVE: get expected `IdToken.Issuer` from OpenId Discovery Document (line#26)

* LINESDK-198 Move send message dialog to internal page

* LINESDK-198 Limit scopes for sharing message to only for internal usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants