Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail error code for internal errors #86

Merged
merged 3 commits into from Sep 1, 2020

Conversation

plateaukao
Copy link
Member

Summary

Add errorCode for LineApiError class, so that when internal error happens, it's easier to identify what kind of error it is by checking the errorCode enum type.

Currently supported types are

    public enum ErrorCode {
        LOGIN_ACTIVITY_NOT_FOUND, // when line-sdk can't find Activity that supports login intent.
        HTTP_RESPONSE_PARSE_ERROR, // when line-sdk can't parse http response from line login server.
        NOT_DEFINED, // when error code is not defined.
    }

Copy link

@JerryMig JerryMig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plateaukao plateaukao merged commit 15370f4 into line:master Sep 1, 2020
@plateaukao plateaukao deleted the add_detail_error_code branch September 1, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants