Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark APIErrorDetail properties as public #115

Merged
merged 2 commits into from Oct 30, 2019
Merged

Mark APIErrorDetail properties as public #115

merged 2 commits into from Oct 30, 2019

Conversation

onevcat
Copy link
Member

@onevcat onevcat commented Oct 29, 2019 •
edited

I received a complaint about getting the error detail code. This fixes #114.

eJamesLin
eJamesLin approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@eJamesLin eJamesLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@onevcat onevcat merged commit a551714 into master Oct 30, 2019
@onevcat onevcat deleted the fix/api-error-detail-public branch October 30, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eJamesLin eJamesLin eJamesLin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal API for APIErrorDetail
2 participants
@onevcat @eJamesLin