Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xcframework action to provide better debug symbol integration #175

Merged
merged 2 commits into from
May 24, 2022

Conversation

onevcat
Copy link
Member

@onevcat onevcat commented May 24, 2022

This PR adopts Xcode 12's -debug-symbols option when creating xcframework. Now it can embed the dSYM and symbol maps into the xcframework bundle, instead of requiring a manual copy into the project.

It would be much easier for framework users to contain the debug info in their apps since Xcode will take the responsibility of extracting and adding these files now.

@onevcat onevcat requested a review from eJamesLin May 24, 2022 03:34
Copy link
Contributor

@eJamesLin eJamesLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@onevcat onevcat merged commit e898754 into master May 24, 2022
@onevcat onevcat deleted the fix/xcframework-renewal branch May 24, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants