Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a getter for raw IDToken in ObjC wrapper #186

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

onevcat
Copy link
Member

@onevcat onevcat commented Jun 7, 2023

This should solve #185

The lack of raw string value of ID Token is unexpected. This PR adds the capability of getting the raw value, so the client can send it to the verify server easier to go through the verifying process.

@onevcat onevcat requested a review from eJamesLin June 7, 2023 00:45
@onevcat
Copy link
Member Author

onevcat commented Jun 7, 2023

@eJamesLin Hi, it is appreciated if you can have a chance to look at it.

Copy link
Contributor

@eJamesLin eJamesLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onevcat onevcat merged commit 389c096 into master Jun 7, 2023
13 checks passed
@onevcat onevcat deleted the fix/public-raw-idtoken-objc branch June 7, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants