Add promptBotID field for multi linked bot feature #188
Conversation
| @@ -37,6 +37,7 @@ public class LoginProcess { | |||
| let botPrompt: LoginManager.BotPrompt? | |||
| let preferredWebPageLanguage: LoginManager.WebPageLanguage? | |||
| let onlyWebLogin: Bool | |||
| let promptBotID: String? | |||
There was a problem hiding this comment.
how about making it var and has default value, which could be less modify to the code and interface?
var promptBotID: String? = nil
There was a problem hiding this comment.
I guess I would prefer to follow the current styles, to make the whole configuration properties immutable. If we want to change it to var ... = nil, I will choose to change all other things too. It is a bit big and worth another PR. (I do not oppose it or have a strong preference on this.)
There was a problem hiding this comment.
OK，currently the LoginManager.Parameters has default nil, and won't impact current users.
|
|
||
| let components = URLComponents(url: result, resolvingAgainstBaseURL: false) | ||
| let items = components!.queryItems! | ||
| XCTAssertEqual(items.count, 2) |
There was a problem hiding this comment.
to make the magic number 2 more readable, how about update to the following?
XCTAssertEqual(items.count, ["loginChannelId", "returnUri"].count)There was a problem hiding this comment.
I will try to update it later (maybe tomorrow!)
|
@eJamesLin I updated the tests a bit for readability as suggested. Please check again! Thanks. |
This added the
promptBotIDparameter to login flow. It allows users to append a linked bot ID to the login URL as query when performing login. For now, this is an internal-only feature so we do not contain any doc or description to it.