Failing builds for Lineage-19.0 due to artifact path requirement

[bananer]

I tried to build lineageos4microg for lineage-19.0 (lineageos4microg/docker-lineage-cicd#243), and it fails with the following output:

FAILED:
build/make/core/artifact_path_requirements.mk:26: warning:  device/google/bramble/lineage_bramble.mk produces files inside build/make/target/product/generic_system.mks artifact path requirement.
Offending entries:
system/app/FDroid/FDroid.apk
system/app/GsfProxy/GsfProxy.apk
system/app/IchnaeaNlpBackend/IchnaeaNlpBackend.apk
system/app/NominatimGeocoderBackend/NominatimGeocoderBackend.apk
system/etc/org.fdroid.fdroid/additional_repos.xml
system/etc/permissions/privapp-permissions-com.android.vending.xml
system/etc/permissions/privapp-permissions-com.aurora.services.xml
system/etc/permissions/privapp-permissions-com.google.android.gms.xml
system/etc/permissions/privapp-permissions-org.fdroid.fdroid.privileged.xml
system/etc/sysconfig/sysconfig-com.google.android.gms.xml
system/priv-app/FDroidPrivilegedExtension/FDroidPrivilegedExtension.apk
system/priv-app/FakeStore/FakeStore.apk
system/priv-app/GmsCore/GmsCore.apk
In file included from build/make/core/main.mk:1346:
build/make/core/artifact_path_requirements.mk:26: error: Build failed.
08:08:48 ckati failed with: exit status 1

This leads me to believe PRODUCT_ENFORCE_ARTIFACT_PATH_REQUIREMENTS was switched on in LineageOS for 19.0 and this repository conflicts with that. I'm not exactly sure if a Product Partition is created when building LineageOS.

One proposed solution I found was to set LOCAL_PRODUCT_MODULE := true in the module definitions. I tried it for another personal repository and it seems like the error line regarding this Apk goes away.

Unsure about the implications of potentially moving our apps from system to product partitions and if that actually would apply.

So far, this is just me noting down what I found out. Any further hints are appreciated.

[bananer]

There are definitely some apps which are marked as "product" by stock LineageOS like DeskClock and Eleven since product_specific in Android.bp has the same meaning as LOCAL_PRODUCT_MODULE in Android.mk as explained here.

I will make the change on a branch product_modules now and try a few builds for both 18.1 and 19.0.

[bananer]

This change is probably incompatible with Android versions before 9.

[bananer]

XML files still not in the right place:

FAILED:                                           
      build/make/core/artifact_path_requirements.mk:26: warning:  device/google/sunfish/lineage_sunfish.mk produces files inside build/make/target/product/generic_system.mks artifact path requirement.                              Offending entries:                                
      system/etc/org.fdroid.fdroid/additional_repos.xml       
system/etc/permissions/privapp-permissions-com.android.vending.xml                                                                                 
system/etc/permissions/privapp-permissions-com.google.android.gms.xml                                           
system/etc/permissions/privapp-permissions-
org.fdroid.fdroid.privileged.xml                                     
system/etc/sysconfig/sysconfig-com.google.android.gms.xml                                                       
In file included from build/make/core/main.mk:1346:     build/make/core/artifact_path_requirements.mk:26: 
error: Build failed.                                         
 19:18:42 ckati failed with: exit status 1

Probably need to change TARGET_OUT_ETC to TARGET_OUT_PRODUCT_ETC