Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure scripts do not continue in case of an unforeseen error. Continuing after an error may lead to a critical step of the process being skipped, thus silently producing the wrong result. Related changes: - Remove two explicit exit code checks, as this checking is now done implicitly by the shell. - Remove the over-zealous trap specification in make_key. The EXIT trap already fires on INT/QUIT signals. - Remove the 'exit 1' statement in make_key. The exit code is already propagated on error. - Switch boolean expression order in make_key to make use of short-circuit evaluation (and thus only evaluate $3 if it is set). - Overwrite existing symlinks when linking signing keys - Ignore SIGPIPE from `yes` - Explicitly allow DEVICE_LIST_xxx variable to be empty - Remove '|| exit' clauses (these had been added only to "cd" commands, in response to a ShellCheck warning); these are now redundant - Temporarily disable strict mode flags when invoking Android build scripts and functions, as these are incompatible with them
- Loading branch information
1 parent
0d9466b
commit ff69cbd
Showing
3 changed files
with
31 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters