resolve comments

linear-protocol · Aug 25, 2023 · 476f8ba · 476f8ba
1 parent bf15024
commit 476f8ba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/contracts/linear/src/epoch_actions.rs b/contracts/linear/src/epoch_actions.rs
@@ -262,11 +262,7 @@ impl LiquidStakingContract {
             .unwrap_or_else(|| panic!("{}: {}", ERR_VALIDATOR_NOT_EXIST, &validator_id));
 
         if is_promise_success() {
-            validator.on_stake_success(
-                &mut self.validator_pool,
-                amount,
-                false, /* release_lock */
-            );
+            validator.on_stake_success(&mut self.validator_pool, amount);
 
             Event::EpochStakeSuccess {
                 validator_id: &validator_id,

diff --git a/contracts/linear/src/validator_pool.rs b/contracts/linear/src/validator_pool.rs
@@ -944,15 +944,8 @@ impl Validator {
         )
     }
 
-    pub fn on_stake_success(
-        &mut self,
-        pool: &mut ValidatorPool,
-        amount: Balance,
-        release_lock: bool,
-    ) {
-        if release_lock {
-            self.post_execution(pool);
-        }
+    pub fn on_stake_success(&mut self, pool: &mut ValidatorPool, amount: Balance) {
+        // Do not post execution here because we need to sync account balance later
         self.staked_amount += amount;
         pool.save_validator(self);
     }