feature:(arrayEquals) fixes 171, search param order shouldn't matter #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nutboltu
reviewed
Jul 5, 2023
| } | ||
|
|
||
| const sortedA = a.sort(); | ||
| const sortedB = b.sort(); |
There was a problem hiding this comment.
sort method mutates the array. we can keep the original array unchanged.
const sortedA = a.slice().sort(); // or [...a].sort()
|
@plumpNation, thanks for your contribution. I left a comment |
|
you might need to fix the prettier as well |
plumpNation
force-pushed
the
171-url-params-order
branch
from
91fe524
to
01477c3
Compare
plumpNation
force-pushed
the
171-url-params-order
branch
from
01477c3
to
6fe543f
Compare
|
Updated the branch, I amended to the original commit. Actually ran lint this time, and added a test for the mutation of the original arrays. |
nutboltu
approved these changes
Jul 6, 2023
|
Thanks for taking this change in so quickly. And many thanks for providing the addon, it's extremely useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the arrayEquals function so that we don't sort before doing cheaper condition checks (isArray, length).
Since the search params array will just be an array of strings maybe a sort on both before every item comparison.
In addition I changed
everytosomeso that it stops iterating once it has found a non match.Fixes #171