feature 174 (mockFetch): add support for aborting requests #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for storybook-addon-mock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
plumpNation
force-pushed
the
174-abort-requests
branch
from
df66039
to
620dc69
Compare
plumpNation
commented
Jul 10, 2023
| }); | ||
|
|
||
| it('should not abort request if aborted signal is not supplied as fetch option', (done) => { | ||
| const abortController = new AbortController(); |
There was a problem hiding this comment.
This seems redundant. I guess I was just thinking about ensuring there was a regression test.
nutboltu
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the mess when creating this review.
I have tried to stay as close to native implementation as I am aware of. I was unable to throw a DOMException because the CI tests are probably running in a node environment.
Fixes #174