fix xhr unmocked reflection #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for storybook-addon-mock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@nutboltu How can we push this forward? |
|
@ItamarGronich, Thanks for your contribution. I'm currently stuck with some priority work. Is it okay if I look at it by this weekend? |
nutboltu
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When making a request to an un-mocked path, we used to swallow errors and any other status code other than 200.
This PR attempts to make a nearly complete API reflection of the fake XHR to the real one.
This fixes #178