Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing properties and methods to response headers #187

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

katarzynaB99
Copy link
Contributor

The response headers lack some of the properties and methods present in the original Headers class.

This PR utilizes the Headers constructor to create the headers object instead of setting each individually.

This fixes #186

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for storybook-addon-mock ready!

Name Link
🔨 Latest commit 79cde04
🔍 Latest deploy log https://app.netlify.com/sites/storybook-addon-mock/deploys/64f9722259250c0008615ab1
😎 Deploy Preview https://deploy-preview-187--storybook-addon-mock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@nutboltu nutboltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @katarzynaB99 for your awesome contribution

@nutboltu
Copy link
Collaborator

nutboltu commented Sep 7, 2023

Looks like there's some linting issue

@katarzynaB99
Copy link
Contributor Author

Oops, sorry! Should be fixed now 😄

@nutboltu nutboltu merged commit 19301d0 into linearlabs-workspace:master Sep 14, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forEach and other properties missing from response headers
2 participants