-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add options to ignore query params #191
Conversation
✅ Deploy Preview for storybook-addon-mock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Resolves #78 |
Hi @nutboltu! |
Yeah. The master pipeline is failing due to missing pollyfills for Header object. You may take a look at it if you have time. I'm AFK and would be able to look later this week. I'll keep you updated. Let me know if you have any urgency. |
Hey! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoaoBrlt just left few comments
@JoaoBrlt apologies, I have to take the "whatwg-fetch" package to pass my other builds. Can you please fix the conflicts. I'll merge this PR then |
@nutboltu No problem, I removed the commit with "whatwg-fetch" and updated the PR to keep only the global option 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @JoaoBrlt !
Changes:
ignoreQueryParams
option (defaults tofalse
) to the mock object config to ignore query parameters on a per-request basis.ignoreQueryParams
option (defaults tofalse
) to the global config to ignore query parameters globally.