Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextBox doesn't reset position after unfocused #1125

Closed
MGlolenstine opened this issue Aug 11, 2020 · 6 comments · Fixed by #1663
Closed

TextBox doesn't reset position after unfocused #1125

MGlolenstine opened this issue Aug 11, 2020 · 6 comments · Fixed by #1663
Labels
bug does not behave the way it is supposed to widget concerns a particular widget

Comments

@MGlolenstine
Copy link
Contributor

MGlolenstine commented Aug 11, 2020

Within the same example from #1124 I've found yet another problem.

If we type more text than there's space for in the first TextBox, the text starts shifting. If we switch to another TextBox and start deleting from the beginning, the weird shift starts showing.
image
In my opinion the text's position should reset when unfocused, at least that's how most of the other applications do it.

EDIT:

This is what happens, when there's no text and only hints remain.
image

@luleyleo luleyleo added bug does not behave the way it is supposed to widget concerns a particular widget labels Aug 14, 2020
@cmyr
Copy link
Member

cmyr commented Aug 17, 2020

Thanks, will keep an eye open for this when I start redoing text stuff in druid (shortly)

@MGlolenstine
Copy link
Contributor Author

Thanks, will keep an eye open for this when I start redoing text stuff in druid (shortly)

You're welcome and thanks for working on it 😉

@cmyr
Copy link
Member

cmyr commented Aug 26, 2020

I think this is really a dupe of your previous issue? As in this describes the problem, and the other issue is capturing aa symptom of that. I would close one of them, maybe the other one?

@MGlolenstine
Copy link
Contributor Author

I wouldn't say it's a dupe, as they describe two different problems, which are both connected to TextBoxes.
If you want to close any of them, feel free to do so.
If I had a say, I'd leave the first one, as it has a MinimalRunnableExample attached.

@cmyr
Copy link
Member

cmyr commented Aug 26, 2020

I think they describe different manifestations of the same problem? If a textbox deselects its contents when it loses focus, (this issue) then that fixes the problem of multiple textboxes having selections simultaneously?

@MGlolenstine
Copy link
Contributor Author

You are indeed correct.

sysint64 added a commit to sysint64/druid that referenced this issue Oct 3, 2020
cmyr added a commit that referenced this issue Oct 5, 2020
* Fix #1124, #1125

* fix clippy

* update CHANGELOG.md

Co-authored-by: Colin Rofls <colin@cmyr.net>
@cmyr cmyr added this to the textbox-polish milestone Mar 18, 2021
cmyr added a commit that referenced this issue Mar 18, 2021
cmyr added a commit that referenced this issue Mar 29, 2021
derekdreery pushed a commit to derekdreery/druid that referenced this issue Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug does not behave the way it is supposed to widget concerns a particular widget
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants