Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues in adapting synthesizer #14

Closed
raphlinus opened this issue Jan 30, 2019 · 1 comment
Closed

Issues in adapting synthesizer #14

raphlinus opened this issue Jan 30, 2019 · 1 comment

Comments

@raphlinus
Copy link
Contributor

This issue collects the rough edges I've run against while adapting the synthesizer.

  • There's some confusion with coordinate types, the old code uses f32 as that's most natural for Windows, yet kurbo tends to use f64. Some of this can be made smoother by adding more into conversions in kurbo taking f32 as well. I'm a little uncertain what we should use as the default. One possibility is the Coord associated type from piet. Basically, there's no compute-time cost for using f64, but it does potentially use more memory if not needed.

  • We should probably merge piet-common: Add type aliases for the associated types piet#37.

  • I am also more inclined to do Deferred errors? piet#34. All the error possibilities are annoying, and not very useful.

  • I missed having a circle shape. This belongs in kurbo, but I'm faking it by using the "circle" from piet-test's picture_1.
This was referenced Jan 30, 2019
Closed
Open
raphlinus added a commit to linebender/piet that referenced this issue Feb 20, 2019
@raphlinus
Add f32 -> f64 conversion
b03221b 
This adds a RoundFrom conversion from f32 to f64, which is especially
convenient when adapting existing code to use Cairo.

This is part of linebender/druid#14
@raphlinus raphlinus mentioned this issue Feb 20, 2019
Merged
raphlinus added a commit to linebender/kurbo that referenced this issue Feb 20, 2019
@raphlinus
Add circle
a31e539 
Part of linebender/druid#14
@raphlinus raphlinus mentioned this issue Feb 20, 2019
Merged
@raphlinus
Copy link
Contributor Author

All these have been addressed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raphlinus