Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix derive Data when type param bounds are defined #1058

Merged
merged 14 commits into from
Jun 30, 2020
Merged

Fix derive Data when type param bounds are defined #1058

merged 14 commits into from
Jun 30, 2020

Conversation

chris-zen
Copy link
Contributor

This PR addresses #1034

@xStrom xStrom added derive concerns a druid-derive feature S-needs-review waits for review labels Jun 25, 2020
luleyleo
luleyleo reviewed Jun 28, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that!

This should be added to the changelog and the tests probably better fit into the druid-derive crate, then we can get this merged.

druid/src/data.rs Outdated Show resolved Hide resolved
@luleyleo luleyleo added S-waiting-on-author waits for changes from the submitter and removed S-needs-review waits for review labels Jun 28, 2020
@chris-zen chris-zen changed the title Fix derive Data when bounds are defined Fix derive Data when type param bounds are defined Jun 29, 2020
@chris-zen
Copy link
Contributor Author

@xStrom @Finnerale I don't know why clipper+test are failing to compile piet-coregraphics.

@cmyr
Copy link
Member

cmyr commented Jun 29, 2020 •
edited
Loading

it's an upstream issue, see linebender/piet#220 & servo/core-foundation-rs#396

@jneem
Copy link
Collaborator

jneem commented Jun 29, 2020

I think the upstream issue is fixed, so I'm re-running the job.

luleyleo
luleyleo reviewed Jun 29, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
luleyleo
luleyleo reviewed Jun 30, 2020
View reviewed changes
CHANGELOG.md Outdated
Comment on lines 30 to 32
- Fix derive `Data` when type param bounds are defined ([#1058] by [@chris-zen])
- Ensure that `update` is called after all commands. ([#1062] by [@jneem])
- Fix derive `Data` when type param bounds are defined ([#1058] by [@chris-zen])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have the entry twice :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ sorry, I messed up while merging.

luleyleo
luleyleo approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be ready now, thanks!

@luleyleo luleyleo merged commit 78698c8 into linebender:master Jun 30, 2020
@chris-zen chris-zen deleted the fix-derive-data branch June 30, 2020 12:59
@jneem jneem mentioned this pull request Aug 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luleyleo luleyleo luleyleo approved these changes

Assignees
No one assigned
Labels
derive concerns a druid-derive feature S-waiting-on-author waits for changes from the submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chris-zen @cmyr @jneem @luleyleo @xStrom